Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3444)

Issue 6652053: code review 6652053: crypto/cipher: panic on invalid iv length (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by shanemhansen
Modified:
11 years, 3 months ago
Reviewers:
CC:
golang-dev, agl1
Visibility:
Public.

Description

crypto/cipher: panic on invalid IV length Give better user feedback when invalid IV is used to construct a cipher. Fixes issue 3411

Patch Set 1 #

Patch Set 2 : diff -r 39b31d81b947 https://code.google.com/p/go #

Patch Set 3 : diff -r 39b31d81b947 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/pkg/crypto/cipher/cbc.go View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/pkg/crypto/cipher/cfb.go View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
shanemhansen
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 6 months ago (2012-10-12 03:45:23 UTC) #1
agl1
LGTM with s/iv/IV/ throughout. Have you signed the ICLA? http://golang.org/doc/contribute.html#copyright
11 years, 6 months ago (2012-10-12 15:23:16 UTC) #2
shanemhansen
Changes made, you should have a ICLA agreement on record for shanemhansen@gmail.com Thanks! --Shane Hansen ...
11 years, 6 months ago (2012-10-12 15:46:31 UTC) #3
agl1
*** Submitted as http://code.google.com/p/go/source/detail?r=d588fe3d90c8 *** crypto/cipher: panic on invalid IV length Give better user feedback ...
11 years, 6 months ago (2012-10-17 18:29:46 UTC) #4
shanemhansen
11 years, 3 months ago (2013-01-09 02:17:18 UTC) #5
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b