Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 6649054: code review 6649054: io/ioutil: use path instead of name to avoid confusion (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by minux1
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

io/ioutil: use pathname instead of name in docs to avoid confusion caller of ioutil.TempFile() can use f.Name() to get "pathname" of the temporary file, instead of just the "name" of the file. Also remove an out-of-date comment about random number state.

Patch Set 1 #

Patch Set 2 : diff -r cfa9208b98fc https://code.google.com/p/go/ #

Patch Set 3 : diff -r cfa9208b98fc https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r a3af77cc3fcd https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r a3af77cc3fcd https://code.google.com/p/go/ #

Patch Set 6 : diff -r a3af77cc3fcd https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/pkg/io/ioutil/tempfile.go View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 6 months ago (2012-10-12 16:58:48 UTC) #1
r
LGTM http://codereview.appspot.com/6649054/diff/3/src/pkg/io/ioutil/tempfile.go File src/pkg/io/ioutil/tempfile.go (right): http://codereview.appspot.com/6649054/diff/3/src/pkg/io/ioutil/tempfile.go#newcode45 src/pkg/io/ioutil/tempfile.go:45: // to find the path of the file. ...
11 years, 6 months ago (2012-10-12 20:48:42 UTC) #2
minux1
On 2012/10/12 20:48:42, r wrote: http://codereview.appspot.com/6649054/diff/3/src/pkg/io/ioutil/tempfile.go#newcode45 > src/pkg/io/ioutil/tempfile.go:45: // to find the path of the ...
11 years, 6 months ago (2012-10-13 06:49:09 UTC) #3
r
LGTM https://codereview.appspot.com/6649054/diff/8002/src/pkg/io/ioutil/tempfile.go File src/pkg/io/ioutil/tempfile.go (right): https://codereview.appspot.com/6649054/diff/8002/src/pkg/io/ioutil/tempfile.go#newcode15 src/pkg/io/ioutil/tempfile.go:15: // Random number state s/$/./
11 years, 6 months ago (2012-10-13 10:52:21 UTC) #4
minux1
11 years, 6 months ago (2012-10-13 11:05:38 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=fc8137c00f9c ***

io/ioutil: use pathname instead of name in docs to avoid confusion
caller of ioutil.TempFile() can use f.Name() to get "pathname"
of the temporary file, instead of just the "name" of the file.

Also remove an out-of-date comment about random number state.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6649054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b