Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 6640056: code review 6640056: cmd/gc: fix inlining bug for composite literals in if s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by remyoudompheng
Modified:
10 years, 1 month ago
Reviewers:
CC:
golang-dev, rsc, remy_archlinux.org
Visibility:
Public.

Description

cmd/gc: fix inlining bug for composite literals in if statements. Fixes issue 4230.

Patch Set 1 #

Patch Set 2 : diff -r 1c5c3c6b15bc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1676e21191aa https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1676e21191aa https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 17dd5c96e4eb https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 65241fa50264 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -4 lines) Patch
M src/cmd/gc/fmt.c View 1 2 3 4 4 chunks +6 lines, -4 lines 0 comments Download
A test/fixedbugs/bug465.go View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A test/fixedbugs/bug465.dir/a.go View 1 1 chunk +61 lines, -0 lines 0 comments Download
A test/fixedbugs/bug465.dir/b.go View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 2 months ago (2012-10-10 23:18:21 UTC) #1
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.
10 years, 2 months ago (2012-10-10 23:19:33 UTC) #2
remyoudompheng
ping?
10 years, 1 month ago (2012-10-17 18:25:16 UTC) #3
remyoudompheng
gentle ping.
10 years, 1 month ago (2012-10-20 19:40:51 UTC) #4
rsc
Instead of introducing a new flag, how about just using ( ) around the if ...
10 years, 1 month ago (2012-10-21 16:26:20 UTC) #5
remyoudompheng
Just tried doing that and it doesnt work due to the simple statements in if/for/switch, ...
10 years, 1 month ago (2012-10-21 18:15:41 UTC) #6
rsc
> Another option is to systematically parenthesize all composite literals. sure
10 years, 1 month ago (2012-10-21 20:13:24 UTC) #7
remyoudompheng
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.
10 years, 1 month ago (2012-10-22 00:17:08 UTC) #8
rsc
LGTM
10 years, 1 month ago (2012-10-22 00:35:38 UTC) #9
remyoudompheng
10 years, 1 month ago (2012-10-22 06:38:27 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=7639aa719ae8 ***

cmd/gc: fix inlining bug for composite literals in if statements.

Fixes issue 4230.

R=golang-dev, rsc
CC=golang-dev, remy
http://codereview.appspot.com/6640056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b