Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1462)

Issue 6631044: code review 6631044: crypto/cipher: add examples (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by agl1
Modified:
11 years, 5 months ago
Reviewers:
CC:
golang-dev, minux1, adg, agl2
Visibility:
Public.

Description

crypto/cipher: add examples Fixes issue 1390.

Patch Set 1 #

Patch Set 2 : diff -r cfbcf8176d26 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cfbcf8176d26 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 4 : diff -r 95b8a6011b40 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 170a9dc2724e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -0 lines) Patch
A src/pkg/crypto/cipher/example_test.go View 1 2 3 1 chunk +283 lines, -0 lines 0 comments Download

Messages

Total messages: 6
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 5 months ago (2012-10-08 19:36:23 UTC) #1
minux1
https://codereview.appspot.com/6631044/diff/1002/src/pkg/crypto/cipher/example_test.go File src/pkg/crypto/cipher/example_test.go (right): https://codereview.appspot.com/6631044/diff/1002/src/pkg/crypto/cipher/example_test.go#newcode16 src/pkg/crypto/cipher/example_test.go:16: func ExampleNewCBCDecrypter(key, ciphertext []byte) ([]byte, error) { example functions ...
11 years, 5 months ago (2012-10-08 19:38:12 UTC) #2
agl1
https://codereview.appspot.com/6631044/diff/1002/src/pkg/crypto/cipher/example_test.go File src/pkg/crypto/cipher/example_test.go (right): https://codereview.appspot.com/6631044/diff/1002/src/pkg/crypto/cipher/example_test.go#newcode16 src/pkg/crypto/cipher/example_test.go:16: func ExampleNewCBCDecrypter(key, ciphertext []byte) ([]byte, error) { On 2012/10/08 ...
11 years, 5 months ago (2012-10-08 19:42:23 UTC) #3
adg
https://codereview.appspot.com/6631044/diff/1002/src/pkg/crypto/cipher/example_test.go File src/pkg/crypto/cipher/example_test.go (right): https://codereview.appspot.com/6631044/diff/1002/src/pkg/crypto/cipher/example_test.go#newcode16 src/pkg/crypto/cipher/example_test.go:16: func ExampleNewCBCDecrypter(key, ciphertext []byte) ([]byte, error) { On 2012/10/08 ...
11 years, 5 months ago (2012-10-12 01:41:55 UTC) #4
agl2
On 2012/10/12 01:41:55, adg wrote: > If you have actual key, ciphertext, and plaintext globals ...
11 years, 5 months ago (2012-10-17 23:21:18 UTC) #5
agl1
11 years, 5 months ago (2012-10-31 20:37:46 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=5f67048f835c ***

crypto/cipher: add examples

Fixes issue 1390.

R=golang-dev, minux.ma, adg, agl
CC=golang-dev
http://codereview.appspot.com/6631044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b