Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1669)

Issue 6624054: code review 6624054: text/template: add an unexported method to Node (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by r
Modified:
1 year, 6 months ago
Reviewers:
CC:
golang-dev, bradfitz, rsc
Visibility:
Public.

Description

text/template: add an unexported method to Node
Protects the package a little against undesirable clients.

Patch Set 1 #

Patch Set 2 : diff -r 3e660456f301 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/pkg/text/template/parse/node.go View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
1 year, 6 months ago #1
bradfitz
LGTM On Fri, Oct 5, 2012 at 2:43 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
1 year, 6 months ago #2
rsc
LGTM (This will also make cmd/api do the right thing automatically for future additions to ...
1 year, 6 months ago #3
r
1 year, 6 months ago #4
*** Submitted as http://code.google.com/p/go/source/detail?r=30663f5bdd69 ***

text/template: add an unexported method to Node
Protects the package a little against undesirable clients.

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/6624054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5