Issue 6622055: code review 6622055: cmd/6g: fix out of registers when chaining integer divi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6622055: code review 6622055: cmd/6g: fix out of registers when chaining integer divi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by remyoudompheng

Modified:
11 years, 6 months ago

Reviewers:

CC:
golang-dev, rsc, remy_archlinux.org

Visibility:
Public.

Description

cmd/6g: fix out of registers when chaining integer divisions. Fixes issue 4201.

Patch Set 1 #

Patch Set 2 : diff -r 3e660456f301 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3e660456f301 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 49b41500176a https://go.googlecode.com/hg/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
	M	src/cmd/6g/cgen.c	View	1	1 chunk	+17 lines, -1 line	0 comments	Download
	M	test/torture.go	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2012-10-06 11:54:17 UTC) #1

remyoudompheng

The fun part is that more invocations of regalloc avoid running out of registers.

11 years, 6 months ago (2012-10-06 11:55:13 UTC) #2

remyoudompheng

11 years, 6 months ago (2012-10-06 22:30:48 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=065fde962295 ***

cmd/6g: fix out of registers when chaining integer divisions.

Fixes issue 4201.

R=golang-dev, rsc
CC=golang-dev, remy
http://codereview.appspot.com/6622055

Expand All Messages | Collapse All Messages