Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(510)

Issue 6622055: code review 6622055: cmd/6g: fix out of registers when chaining integer divi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by remyoudompheng
Modified:
1 year, 6 months ago
Reviewers:
CC:
golang-dev, rsc, remy_archlinux.org
Visibility:
Public.

Description

cmd/6g: fix out of registers when chaining integer divisions.

Fixes issue 4201.

Patch Set 1 #

Patch Set 2 : diff -r 3e660456f301 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3e660456f301 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 49b41500176a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M src/cmd/6g/cgen.c View 1 1 chunk +17 lines, -1 line 0 comments Download
M test/torture.go View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 6 months ago #1
remyoudompheng
The fun part is that more invocations of regalloc avoid running out of registers.
1 year, 6 months ago #2
rsc
LGTM
1 year, 6 months ago #3
remyoudompheng
1 year, 6 months ago #4
*** Submitted as http://code.google.com/p/go/source/detail?r=065fde962295 ***

cmd/6g: fix out of registers when chaining integer divisions.

Fixes issue 4201.

R=golang-dev, rsc
CC=golang-dev, remy
http://codereview.appspot.com/6622055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5