Issue 6620074: code review 6620074: fmt: document some undocumented details

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6620074: code review 6620074: fmt: document some undocumented details (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by r

Modified:
11 years, 6 months ago

Reviewers:

CC:
golang-dev, adg, rsc, iant

Visibility:
Public.

Description

fmt: document some undocumented details Better explanation of width for floating-point values. Explain that scanning does not handle %#q etc. Fixes issue 4202. Fixes issue 4206.

Patch Set 1 #

Patch Set 2 : diff -r 3350c94fe6b7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3350c94fe6b7 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 67edfdb4413a https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	src/pkg/fmt/doc.go	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2012-10-08 05:55:11 UTC) #1

rsc

FWIW, the definition of precision is different for %e/%E/%f (digits after decimal) than it is ...

11 years, 6 months ago (2012-10-08 14:44:13 UTC) #4

Hello golang-dev@googlegroups.com, adg@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

11 years, 6 months ago (2012-10-08 23:50:58 UTC) #5

11 years, 6 months ago (2012-10-12 05:17:38 UTC) #8

*** Submitted as http://code.google.com/p/go/source/detail?r=a9280640383f ***

fmt: document some undocumented details
Better explanation of width for floating-point values.
Explain that scanning does not handle %#q etc.

Fixes issue 4202.
Fixes issue 4206.

R=golang-dev, adg, rsc, iant
CC=golang-dev
http://codereview.appspot.com/6620074

Expand All Messages | Collapse All Messages