Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 6620067: code review 6620067: cmd/gc: avoid clobbering the AST in cgen_callmeth. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by remyoudompheng
Modified:
2 years, 7 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/gc: avoid clobbering the AST in cgen_callmeth. It confused the detection of init loops when involving method calls. Fixes issue 3890.

Patch Set 1 #

Patch Set 2 : diff -r 065fde962295 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 065fde962295 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 065fde962295 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -7 lines) Patch
M src/cmd/gc/gen.c View 1 1 chunk +9 lines, -7 lines 0 comments Download
M src/cmd/gc/sinit.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
A test/fixedbugs/bug459.go View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
2 years, 7 months ago (2012-10-06 22:45:14 UTC) #1
rsc
LGTM Thanks for tracking that down!
2 years, 7 months ago (2012-10-06 22:51:02 UTC) #2
remyoudompheng
2 years, 7 months ago (2012-10-06 22:52:43 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=e2ec9e45d282 ***

cmd/gc: avoid clobbering the AST in cgen_callmeth.

It confused the detection of init loops when involving
method calls.

Fixes issue 3890.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6620067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5