code review 6619067: doc: update text about hgrc and environment variables.

doc: update text about hgrc and environment variables.

Mercurial has supported environment variables in hgrc files since
version 1.4 (released November 2009).

[dsymonds, 2012-10-08 10:11:05]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-10-08 10:11:25]

Reference:
http://mercurial.selenic.com/wiki/TipsAndTricks#Using_environment_variables_i...

[dfc, 2012-10-08 10:14:05]

On 2012/10/08 10:11:25, dsymonds wrote:
> Reference:
>
http://mercurial.selenic.com/wiki/TipsAndTricks#Using_environment_variables_i...

LGTM. Thank you.

[minux1, 2012-10-08 10:18:18]

https://codereview.appspot.com/6619067/diff/4001/doc/contribute.html
File doc/contribute.html (right):

https://codereview.appspot.com/6619067/diff/4001/doc/contribute.html#newcode113
doc/contribute.html:113: codereview = $GOROOT/lib/codereview/codereview.py
one possible problem:
we don't advertise people to set GOROOT these days...
(in fact, we embed GOROOT in cmd/go so that people don't
need to bother it)

Is there any better ways to find the plugin?

[dsymonds, 2012-10-08 10:33:30]

https://codereview.appspot.com/6619067/diff/4001/doc/contribute.html
File doc/contribute.html (right):

https://codereview.appspot.com/6619067/diff/4001/doc/contribute.html#newcode113
doc/contribute.html:113: codereview = $GOROOT/lib/codereview/codereview.py
On 2012/10/08 10:18:19, minux wrote:
> one possible problem:
> we don't advertise people to set GOROOT these days...
> (in fact, we embed GOROOT in cmd/go so that people don't
> need to bother it)
> 
> Is there any better ways to find the plugin?

The rest of this doc is already assuming $GOROOT is set. It's aimed at
contributors with a clone of the Hg tree. I think it's reasonable to assume they
can set $GOROOT, or at least swap it out here if they really don't want to set
one.

[minux1, 2012-10-08 10:44:24]

On 2012/10/08 10:33:30, dsymonds wrote:
> The rest of this doc is already assuming $GOROOT is set. It's aimed at
> contributors with a clone of the Hg tree. I think it's reasonable to assume
they
> can set $GOROOT, or at least swap it out here if they really don't want to set
> one.
Fair enough. (I don't set $GOROOT, but run.bash assumes it is set, so i think
it's
indeed mandatory)
LGTM.

[dsymonds, 2012-10-08 11:24:49]

*** Submitted as http://code.google.com/p/go/source/detail?r=4261c157f226 ***

doc: update text about hgrc and environment variables.

Mercurial has supported environment variables in hgrc files since
version 1.4 (released November 2009).

R=golang-dev, dave, minux.ma
CC=golang-dev
http://codereview.appspot.com/6619067