Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 6619057: code review 6619057: cmd/gc: make rnd() more 64-bit-friendly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by remyoudompheng
Modified:
1 year, 6 months ago
Reviewers:
CC:
golang-dev, dfc, rsc
Visibility:
Public.

Description

cmd/gc: make rnd() more 64-bit-friendly.

Fixes issue 4200.

Patch Set 1 #

Patch Set 2 : diff -r 2aef5548a9cf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2aef5548a9cf https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 311d011a9e0b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M src/cmd/gc/align.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/gc/go.h View 1 1 chunk +1 line, -1 line 0 comments Download
A test/fixedbugs/bug458.go View 1 2 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 6 months ago #1
dfc
Is it possible to make this the native word size for the machine. rnd() is ...
1 year, 6 months ago #2
remyoudompheng
The compiler already uses vlongs everywhere so I doubt it would change things a lot. ...
1 year, 6 months ago #3
rsc
On Sat, Oct 6, 2012 at 6:51 AM, <dave@cheney.net> wrote: > Is it possible to ...
1 year, 6 months ago #4
rsc
LGTM
1 year, 6 months ago #5
remyoudompheng
1 year, 6 months ago #6
*** Submitted as http://code.google.com/p/go/source/detail?r=49b41500176a ***

cmd/gc: make rnd() more 64-bit-friendly.

Fixes issue 4200.

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6619057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5