Issue 6618064: iam: added CreateAccessKey method

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6618064: iam: added CreateAccessKey method (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by fss

Modified:
11 years, 7 months ago

Reviewers:
mp+128495, niemeyer

Visibility:
Public.

Description

iam: added CreateAccessKey method https://code.launchpad.net/~franciscosouza/goamz/iam-createkeypair/+merge/128495 (do not edit description out of merge proposal)

Patch Set 2 : iam: added CreateAccessKey method #

Patch Set 3 : iam: added CreateAccessKey method #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -1 line)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	iam/iam.go	View	1 2	2 chunks	+34 lines, -1 line	0 comments	Download
M	iam/iam_test.go	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	iam/responses_test.go	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

niemeyer

Also great, with just trivials: https://codereview.appspot.com/6618064/diff/1/iam/iam.go File iam/iam.go (right): https://codereview.appspot.com/6618064/diff/1/iam/iam.go#newcode108 iam/iam.go:108: RequestId string `xml:"ResponseMetadata>RequestId"` Can ...

11 years, 7 months ago (2012-10-08 14:23:00 UTC) #2

fss

Please take a look. https://codereview.appspot.com/6618064/diff/1/iam/iam.go File iam/iam.go (right): https://codereview.appspot.com/6618064/diff/1/iam/iam.go#newcode108 iam/iam.go:108: RequestId string `xml:"ResponseMetadata>RequestId"` On 2012/10/08 ...

11 years, 7 months ago (2012-10-08 14:33:59 UTC) #3

niemeyer

*** Submitted: iam: added CreateAccessKey method R=niemeyer CC= https://codereview.appspot.com/6618064

11 years, 7 months ago (2012-10-10 15:23:08 UTC) #5

LGTM

Expand All Messages | Collapse All Messages