Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17)

Issue 6614056: acme: execute "hard" runs in $SHELL when available.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by marius.eriksen
Modified:
2 years, 6 months ago
Reviewers:
rsc
CC:
rsc, codebot
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : use $acmeshell; hard by deafult #

Patch Set 3 : warning on shell, not acmeshell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M man/man1/acme.1 View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/cmd/acme/acme.c View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/acme/dat.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/acme/exec.c View 1 2 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8
marius.eriksen
2 years, 6 months ago (2012-10-07 04:20:45 UTC) #1
marius.eriksen
This is mostly an RFC: it does create issues with quoting inconsistency with quoting. Eg. ...
2 years, 6 months ago (2012-10-07 04:23:07 UTC) #2
rsc
For better or worse acme's execution model hard-codes rc's behavior, so that's the shell that ...
2 years, 6 months ago (2012-10-07 14:01:34 UTC) #3
marius.eriksen
2 years, 6 months ago (2012-10-07 21:10:58 UTC) #4
marius.eriksen
That makes sense.
2 years, 6 months ago (2012-10-07 21:11:29 UTC) #5
marius.eriksen
2 years, 6 months ago (2012-10-07 21:12:38 UTC) #6
rsc
LGTM
2 years, 6 months ago (2012-10-21 20:52:13 UTC) #7
rsc
2 years, 6 months ago (2012-10-21 20:52:13 UTC) #8
*** Submitted as http://code.google.com/p/plan9port/source/detail?r=dfcebf03fe71
***

acme: add $acmeshell to control execution shell

R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6614056

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5