Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(629)

Issue 6613069: code review 6613069: testing: fix extra tabs when t.Log("string") (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by minux1
Modified:
9 years, 2 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

testing: fix extra tabs when t.Log("string") t.Log("line 1\nline 2\nline 3") Old output: === RUN TestLine3 --- PASS: TestLine3 (0.00 seconds) testing_test.go:25: line 1 line 2 line 3 PASS New output: === RUN TestLine3 --- PASS: TestLine3 (0.00 seconds) testing_test.go:24: line 1 line 2 line 3 PASS

Patch Set 1 #

Patch Set 2 : diff -r 7b037816cd5c https://code.google.com/p/go/ #

Patch Set 3 : diff -r 986908b3e4ae https://code.google.com/p/go/ #

Patch Set 4 : diff -r abd56df63b8f https://code.google.com/p/go/ #

Patch Set 5 : diff -r abd56df63b8f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/pkg/testing/testing.go View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 2 months ago (2012-10-07 15:51:18 UTC) #1
rsc
LGTM
9 years, 2 months ago (2012-10-07 16:08:57 UTC) #2
minux1
9 years, 2 months ago (2012-10-07 16:22:08 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=cdb83cb72d03 ***

testing: fix extra tabs when t.Log("string")

t.Log("line 1\nline 2\nline 3")

Old output:
=== RUN TestLine3
--- PASS: TestLine3 (0.00 seconds)
testing_test.go:25: 	line 1
		line 2
		line 3
		PASS

New output:
=== RUN TestLine3
--- PASS: TestLine3 (0.00 seconds)
testing_test.go:24: 	line 1
		line 2
		line 3
PASS

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6613069
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b