Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(390)

Issue 6612049: code review 6612049: exp/types/staging: more flexible API, cleanups (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by gri
Modified:
9 years, 1 month ago
Reviewers:
CC:
golang-dev, r, rsc
Visibility:
Public.

Description

exp/types/staging: more flexible API, cleanups - Changed Check signature to take function parameters for more flexibility: Now a client can interrupt type checking early (via panic in one the upcalls) once the desired type information or number of errors is reached. Default use is still simple. - Cleaned up main typechecking loops. Now does not neglect _ declarations anymore. - Various other cleanups.

Patch Set 1 #

Patch Set 2 : diff -r fc0c1a909822 https://code.google.com/p/go #

Patch Set 3 : diff -r fc0c1a909822 https://code.google.com/p/go #

Patch Set 4 : diff -r fc0c1a909822 https://code.google.com/p/go #

Total comments: 5

Patch Set 5 : diff -r 21aca6261767 https://code.google.com/p/go #

Patch Set 6 : diff -r 0a11e5a60d9c https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -193 lines) Patch
M src/pkg/exp/types/staging/check.go View 1 2 3 4 5 chunks +184 lines, -154 lines 0 comments Download
M src/pkg/exp/types/staging/errors.go View 1 2 3 chunks +26 lines, -23 lines 0 comments Download
M src/pkg/exp/types/staging/gcimporter.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/exp/types/staging/gcimporter_test.go View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/pkg/exp/types/staging/types.go View 1 2 3 4 1 chunk +8 lines, -13 lines 0 comments Download

Messages

Total messages: 5
gri
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 1 month ago (2012-10-05 02:35:46 UTC) #1
r
http://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/types.go File src/pkg/exp/types/staging/types.go (right): http://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/types.go#newcode24 src/pkg/exp/types/staging/types.go:24: // is found. A nil record is not invoked. ...
9 years, 1 month ago (2012-10-06 22:25:59 UTC) #2
rsc
LGTM https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/check.go File src/pkg/exp/types/staging/check.go (right): https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/check.go#newcode286 src/pkg/exp/types/staging/check.go:286: // TODO(gri) why is _ special here? I ...
9 years, 1 month ago (2012-10-06 22:49:46 UTC) #3
gri
https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/check.go File src/pkg/exp/types/staging/check.go (right): https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/check.go#newcode286 src/pkg/exp/types/staging/check.go:286: // TODO(gri) why is _ special here? On 2012/10/06 ...
9 years, 1 month ago (2012-10-07 23:40:47 UTC) #4
gri
9 years, 1 month ago (2012-10-08 01:02:29 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=ad44ea247aa4 ***

exp/types/staging: more flexible API, cleanups

- Changed Check signature to take function parameters for
  more flexibility: Now a client can interrupt type checking
  early (via panic in one the upcalls) once the desired
  type information or number of errors is reached. Default
  use is still simple.

- Cleaned up main typechecking loops. Now does not neglect
  _ declarations anymore.

- Various other cleanups.

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/6612049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b