code review 6612049: exp/types/staging: more flexible API, cleanups

exp/types/staging: more flexible API, cleanups

- Changed Check signature to take function parameters for
  more flexibility: Now a client can interrupt type checking
  early (via panic in one the upcalls) once the desired
  type information or number of errors is reached. Default
  use is still simple.

- Cleaned up main typechecking loops. Now does not neglect
  _ declarations anymore.

- Various other cleanups.

[gri, 2012-10-05 02:35:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2012-10-06 22:25:59]

http://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/typ...
File src/pkg/exp/types/staging/types.go (right):

http://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/typ...
src/pkg/exp/types/staging/types.go:24: // is found. A nil record is not invoked.
what does "A nil record is not invoked" mean?

[rsc, 2012-10-06 22:49:46]

LGTM

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/ch...
File src/pkg/exp/types/staging/check.go (right):

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/ch...
src/pkg/exp/types/staging/check.go:286: // TODO(gri) why is _ special here?
I can imagine it might be special in that you still want to type-check the
declaration. That is:

var _ int = "hello"

should not be thrown away before being type-checked. But that's also true of
case TypeSpec.

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/ty...
File src/pkg/exp/types/staging/types.go (right):

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/ty...
src/pkg/exp/types/staging/types.go:24: // is found. A nil record is not invoked.
On 2012/10/06 22:25:59, r wrote:
> what does "A nil record is not invoked" mean?

s//If record is nil, it is not invoked./

And maybe chage record to f or save or something more obviously a function or
verb.

[gri, 2012-10-07 23:40:47]

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/ch...
File src/pkg/exp/types/staging/check.go (right):

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/ch...
src/pkg/exp/types/staging/check.go:286: // TODO(gri) why is _ special here?
On 2012/10/06 22:49:46, rsc wrote:
> I can imagine it might be special in that you still want to type-check the
> declaration. That is:
> 
> var _ int = "hello"
> 
> should not be thrown away before being type-checked. But that's also true of
> case TypeSpec.

Correct. There's a failure here that I haven't tracked down yet.

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/ty...
File src/pkg/exp/types/staging/types.go (right):

https://codereview.appspot.com/6612049/diff/7001/src/pkg/exp/types/staging/ty...
src/pkg/exp/types/staging/types.go:24: // is found. A nil record is not invoked.
On 2012/10/06 22:49:46, rsc wrote:
> On 2012/10/06 22:25:59, r wrote:
> > what does "A nil record is not invoked" mean?
> 
> s//If record is nil, it is not invoked./
> 
> And maybe chage record to f or save or something more obviously a function or
> verb.
> 

Done.

[gri, 2012-10-08 01:02:29]

*** Submitted as http://code.google.com/p/go/source/detail?r=ad44ea247aa4 ***

exp/types/staging: more flexible API, cleanups

- Changed Check signature to take function parameters for
  more flexibility: Now a client can interrupt type checking
  early (via panic in one the upcalls) once the desired
  type information or number of errors is reached. Default
  use is still simple.

- Cleaned up main typechecking loops. Now does not neglect
  _ declarations anymore.

- Various other cleanups.

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/6612049