Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1104)

Issue 6610066: code review 6610066: os: Added documentation to the Exit function

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by kln
Modified:
8 years, 10 months ago
CC:
golang-codereviews
Visibility:
Public.

Description

os: Added documentation to the Exit function Added documentation for the Exit function indicating that when calling Exit, any defer statements that have been called never actually get executed. Fixes issue 4101.

Patch Set 1 #

Patch Set 2 : diff -r 0e7dab91ba8e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1571ae601243 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 1571ae601243 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 1571ae601243 https://code.google.com/p/go/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/pkg/os/proc.go View 1 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 24
kln
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 2 months ago (2012-10-07 21:36:30 UTC) #1
r
I'm not sure whether the behavior should be documented or changed.
10 years, 2 months ago (2012-10-08 00:22:28 UTC) #2
klnusbaum_gmail.com
According to the Go Language specification: "A 'defer' statement invokes a function whose execution is ...
10 years, 2 months ago (2012-10-08 01:44:49 UTC) #3
0xjnml
Erroneously sent to OP only, FWDing now. ---------- Forwarded message ---------- From: Jan Mercl <0xjnml@gmail.com> ...
10 years, 2 months ago (2012-10-08 08:09:24 UTC) #4
lucio
I was trying to imagine how far one takes this, if deferred functions need to ...
10 years, 2 months ago (2012-10-08 10:53:50 UTC) #5
rsc
On Sun, Oct 7, 2012 at 8:22 PM, Rob Pike <r@golang.org> wrote: > I'm not ...
10 years, 2 months ago (2012-10-08 14:50:57 UTC) #6
klnusbaum_gmail.com
Russ, I actually think you're reasoning is pretty sound on this one. I fully agree. ...
10 years, 2 months ago (2012-10-08 16:04:39 UTC) #7
gri
For what it's worth: LGTM I agree w/ the various comments that the behavior of ...
10 years, 2 months ago (2012-10-08 18:38:31 UTC) #8
klnusbaum_gmail.com
gri, I'm not a committer. Can you please run: $hg clpatch 6610066 $hg submit 6610066 ...
10 years, 2 months ago (2012-10-08 19:29:26 UTC) #9
gri
I was aware of that. But I am leaving this for feedback from others (r, ...
10 years, 2 months ago (2012-10-08 19:31:12 UTC) #10
klnusbaum_gmail.com
Ah ok. Sorry, didn't realize that. I'll wait then :) On Mon, Oct 8, 2012 ...
10 years, 2 months ago (2012-10-08 19:31:59 UTC) #11
r
I'd be happier if the spec was clearer. It says the deferred function runs "when ...
10 years, 2 months ago (2012-10-08 20:05:03 UTC) #12
kln
Hello golang-dev@googlegroups.com, r@golang.org, 0xjnml@gmail.com, lucio.dere@gmail.com, rsc@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 2 months ago (2012-10-09 22:34:52 UTC) #13
kln
Hello golang-dev@googlegroups.com, r@golang.org, 0xjnml@gmail.com, lucio.dere@gmail.com, rsc@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 2 months ago (2012-10-09 22:37:16 UTC) #14
r
Still waiting for a response from others about my request to tweak the spec. -rob
10 years, 2 months ago (2012-10-09 23:40:21 UTC) #15
klnusbaum_gmail.com
Any response on the spec tweak? On Tue, Oct 9, 2012 at 6:40 PM, Rob ...
10 years, 1 month ago (2012-10-23 03:53:51 UTC) #16
gri
I will look into this tomorrow. - gri On Mon, Oct 22, 2012 at 8:53 ...
10 years, 1 month ago (2012-10-23 04:04:59 UTC) #17
lvd
syscall.Exec doesn't return either, and whether to call that or Exit is a deliberate choice ...
10 years, 1 month ago (2012-10-23 11:05:10 UTC) #18
gri
See: http://codereview.appspot.com/6736071 - gri On Mon, Oct 22, 2012 at 9:04 PM, Robert Griesemer <gri@golang.org> ...
10 years, 1 month ago (2012-10-23 22:41:24 UTC) #19
klnusbaum_gmail.com
So what should I do with 6610066? Should I just delete this patch? On Tue, ...
10 years, 1 month ago (2012-11-01 20:55:19 UTC) #20
r
http://codereview.appspot.com/6610066/diff/17001/src/pkg/os/proc.go File src/pkg/os/proc.go (right): http://codereview.appspot.com/6610066/diff/17001/src/pkg/os/proc.go#newcode37 src/pkg/os/proc.go:37: // function is reached. now the spec has the ...
10 years, 1 month ago (2012-11-02 00:38:17 UTC) #21
lucio
On 2012/11/02 00:38:17, r wrote: > http://codereview.appspot.com/6610066/diff/17001/src/pkg/os/proc.go > File src/pkg/os/proc.go (right): > > http://codereview.appspot.com/6610066/diff/17001/src/pkg/os/proc.go#newcode37 > ...
9 years, 6 months ago (2013-06-02 05:28:03 UTC) #22
gobot
Replacing golang-dev with golang-codereviews.
8 years, 11 months ago (2013-12-20 16:21:40 UTC) #23
dfc
8 years, 10 months ago (2014-02-05 03:01:57 UTC) #24
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b