Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(153)

Issue 6601043: code review 6601043: go.crypto/ssh: new package: sshtest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by dfc
Modified:
9 years ago
Reviewers:
CC:
agl1, gpaul, kardia, albert.strasheim, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: new test subpackage This proposal is an attempt to improve the state of functional testing in the ssh package. The previous functional tests required the user to give away some personal details, like their password and private key to run the tests, and so were probably not run as frequently as they should.

Patch Set 1 #

Patch Set 2 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 7 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Total comments: 6

Patch Set 8 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 9 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 10 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 11 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 12 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Patch Set 13 : diff -r aab880ed1ec2 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -130 lines) Patch
R ssh/client_func_test.go View 1 1 chunk +0 lines, -110 lines 0 comments Download
A ssh/test/doc.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +7 lines, -0 lines 0 comments Download
A ssh/test/session_test.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +101 lines, -0 lines 0 comments Download
M ssh/test/tcpip_test.go View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +8 lines, -20 lines 0 comments Download
A ssh/test/test_unix_test.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +294 lines, -0 lines 0 comments Download

Messages

Total messages: 13
dfc
Hello agl@golang.org, gustav.paul@gmail.com, kardianos@gmail.com, fullung@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...
9 years ago (2012-10-03 10:52:48 UTC) #1
dfc
Hello agl@golang.org, gustav.paul@gmail.com, kardianos@gmail.com, fullung@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years ago (2012-10-03 11:22:36 UTC) #2
dfc
On 2012/10/03 11:22:36, dfc wrote: > Hello mailto:agl@golang.org, mailto:gustav.paul@gmail.com, mailto:kardianos@gmail.com, > mailto:fullung@gmail.com (cc: mailto:golang-dev@googlegroups.com), > ...
9 years ago (2012-10-03 12:47:09 UTC) #3
agl1
https://codereview.appspot.com/6601043/diff/10001/ssh/sshtest/auth_test.go File ssh/sshtest/auth_test.go (right): https://codereview.appspot.com/6601043/diff/10001/ssh/sshtest/auth_test.go#newcode86 ssh/sshtest/auth_test.go:86: func (k *keychain) loadPEM(file string) error { It's not ...
9 years ago (2012-10-03 20:14:22 UTC) #4
dfc
Thank you for your comments. I'm attempting a version of the harness that uses sshd ...
9 years ago (2012-10-04 04:56:57 UTC) #5
dfc
Hello agl@golang.org, gustav.paul@gmail.com, kardianos@gmail.com, fullung@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years ago (2012-10-04 06:06:15 UTC) #6
kardia
On windows only build tcpip_test.go and not the other tests. Otherwise looks fine as far ...
9 years ago (2012-10-04 06:28:35 UTC) #7
dfc
None of these will work on windows (no sshd). Maybe I should use // +build ...
9 years ago (2012-10-04 06:30:31 UTC) #8
dfc
PTAL. I have reworked the file layout to run these tests on unix platforms only. ...
9 years ago (2012-10-04 07:47:18 UTC) #9
kardia
On 2012/10/04 07:47:18, dfc wrote: > PTAL. I have reworked the file layout to run ...
9 years ago (2012-10-04 15:04:46 UTC) #10
agl1
LGTM. Is go.crypto/ssh/sshtest a stutter? Should it be go.crypto/ssh/test? Up to you.
9 years ago (2012-10-04 16:18:57 UTC) #11
dfc
On 2012/10/04 16:18:57, agl1 wrote: > LGTM. > > Is go.crypto/ssh/sshtest a stutter? Should it ...
9 years ago (2012-10-05 01:09:51 UTC) #12
dfc
9 years ago (2012-10-05 01:11:16 UTC) #13
*** Submitted as
http://code.google.com/p/go/source/detail?r=671a5c2bfac2&repo=crypto ***

go.crypto/ssh: new test subpackage

This proposal is an attempt to improve the state of functional testing in the
ssh package. The previous functional tests required the user to give away some
personal details, like their password and private key to run the tests, and so
were probably not run as frequently as they should.

R=agl, gustav.paul, kardianos, fullung
CC=golang-dev
http://codereview.appspot.com/6601043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b