Issue 6598047: Introduce global Intl namespace - alias v8Intl to Intl.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6598047: Introduce global Intl namespace - alias v8Intl to Intl. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by cira1

Modified:
11 years, 6 months ago

Reviewers:
jungshik, jshin

CC:
v8-dev_googlegroups.com

Base URL:
http://v8-i18n.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This change introduces Intl object into global namespace. We discussed the name at the EcmaScript TC39 meetings and decided that it shouldn't break any of the major libraries, so it became part of the ECMA 402 standard. v8Intl object is aliased to Intl so we don't expect any problems with existing clients (ChromeOS, Drive, some Chrome apps).

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -58 lines)			Patch
M	src/break-iterator.js	View	4 chunks	+10 lines, -10 lines	0 comments	Download
M	src/collator.js	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/date-format.js	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/footer.js	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/header.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/number-format.js	View	4 chunks	+8 lines, -8 lines	0 comments	Download
D	tests/adapter.js	View	1 chunk	+0 lines, -18 lines	0 comments	Download
A	tests/intl/general/v8Intl-exists.js	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	tests/intl/run-tests.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/test262/run-tests.py	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages