Issue 6593061: state: rename PathKey to EntityName

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6593061: state: rename PathKey to EntityName

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rog

Modified:
11 years, 7 months ago

Reviewers:
mp+127459

Visibility:
Public.

Description

state: rename PathKey to EntityName The name suggested in an earlier CL, "Key" isn't great because entities already have keys and they're not the same, so I'm going with an earlier suggestion for the time being. https://code.launchpad.net/~rogpeppe/juju-core/098-state-entity-name/+merge/127459 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: rename PathKey to EntityName #

Patch Set 3 : state: rename PathKey to EntityName #

Patch Set 4 : state: rename PathKey to EntityName #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -23 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/unit_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cmd/jujud/upgrade.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/jujud/upgrade_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	container/container.go	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	state/machine.go	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	state/machine_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	state/unit.go	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
M	state/unit_test.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	worker/uniter/uniter.go	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

11 years, 7 months ago (2012-10-02 14:46:11 UTC) #3

*** Submitted:

state: rename PathKey to EntityName

The name suggested in an earlier CL, "Key" isn't great because entities
already have keys and they're not the same, so I'm going with
an earlier suggestion for the time being.

R=niemeyer
CC=
https://codereview.appspot.com/6593061

Expand All Messages | Collapse All Messages