Issue 6593053: cmd/juju: implement upgrade-juju --bump-version

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6593053: cmd/juju: implement upgrade-juju --bump-version

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rog

Modified:
11 years, 7 months ago

Reviewers:
mp+127252

Visibility:
Public.

Description

cmd/juju: implement upgrade-juju --bump-version https://code.launchpad.net/~rogpeppe/juju-core/095-juju-upgrade-version/+merge/127252 (do not edit description out of merge proposal)

Patch Set 2 : cmd/juju: implement upgrade-juju --bump-version #

Total comments: 2

Patch Set 3 : cmd/juju: implement upgrade-juju --bump-version #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/upgradejuju.go	View	4 chunks	+24 lines, -0 lines	0 comments	Download
M	cmd/juju/upgradejuju_test.go	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Just one consideration regarding the logic: https://codereview.appspot.com/6593053/diff/2001/cmd/juju/upgradejuju.go File cmd/juju/upgradejuju.go (right): https://codereview.appspot.com/6593053/diff/2001/cmd/juju/upgradejuju.go#newcode80 cmd/juju/upgradejuju.go:80: c.Version = vers.Number ...

11 years, 7 months ago (2012-10-01 14:16:47 UTC) #2

rog

11 years, 7 months ago (2012-10-01 14:32:59 UTC) #4

*** Submitted:

cmd/juju: implement upgrade-juju --bump-version

R=niemeyer
CC=
https://codereview.appspot.com/6593053

Expand All Messages | Collapse All Messages