Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 6591076: code review 6591076: go.net/ipv4: remove arguments from example functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by mikio
Modified:
9 years, 8 months ago
Reviewers:
CC:
iant, dfc, minux1, adg, golang-dev
Visibility:
Public.

Description

go.net/ipv4: remove arguments from example functions The testing packege expects that Example functions in each package don't take any arguments. Will do so for the safety.

Patch Set 1 #

Patch Set 2 : diff -r ea9c842f8912 https://code.google.com/p/go.net #

Patch Set 3 : diff -r ea9c842f8912 https://code.google.com/p/go.net #

Patch Set 4 : diff -r 838dac337e60 https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M ipv4/example_test.go View 1 2 chunks +36 lines, -5 lines 0 comments Download

Messages

Total messages: 10
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net
9 years, 10 months ago (2012-10-04 06:08:46 UTC) #1
mikio
ping
9 years, 10 months ago (2012-10-13 17:15:11 UTC) #2
iant
This change does more than simply remove the arguments, and it will fail to run ...
9 years, 10 months ago (2012-10-13 17:45:02 UTC) #3
dfc
On 2012/10/13 17:45:02, iant wrote: > This change does more than simply remove the arguments, ...
9 years, 10 months ago (2012-10-13 23:52:25 UTC) #4
dfc
I would LGTM this, but looking at the examples in godoc, none of them are ...
9 years, 10 months ago (2012-10-13 23:55:23 UTC) #5
minux1
+adg. On 2012/10/13 23:55:23, dfc wrote: > [...] but looking at the examples in godoc, ...
9 years, 10 months ago (2012-10-14 08:52:48 UTC) #6
mikio
Thanks for comments, iant, dfc and minux. Looks like addressed questionable things on this CL ...
9 years, 10 months ago (2012-10-16 07:00:22 UTC) #7
mikio
hello adg, ping.
9 years, 9 months ago (2012-11-16 10:50:51 UTC) #8
adg
LGTM
9 years, 8 months ago (2012-11-30 12:33:34 UTC) #9
mikio
9 years, 8 months ago (2012-11-30 16:06:14 UTC) #10
*** Submitted as
https://code.google.com/p/go/source/detail?r=3f49abc52b3c&repo=net ***

go.net/ipv4: remove arguments from example functions

The testing packege expects that Example functions in each
package don't take any arguments. Will do so for the safety.

R=iant, dave, minux.ma, adg
CC=golang-dev
https://codereview.appspot.com/6591076
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b