Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(170)

Issue 6591047: GSoC 2012 NS-3 LTE MAC Scheduler Project

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by Dizhi.Zhou
Modified:
9 years, 7 months ago
Reviewers:
Tom Henderson
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

GSoC 2012 NS-3 LTE MAC Scheduler Project

Patch Set 1 #

Total comments: 14
Unified diffs Side-by-side diffs Delta from patch set Stats (+17225 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M RELEASE_NOTES View 1 chunk +2 lines, -0 lines 0 comments Download
M src/lte/AUTHORS View 1 chunk +13 lines, -0 lines 0 comments Download
M src/lte/doc/source/lte-design.rst View 1 chunk +170 lines, -0 lines 4 comments Download
M src/lte/doc/source/lte-references.rst View 2 chunks +6 lines, -1 line 2 comments Download
M src/lte/doc/source/lte-testing.rst View 1 chunk +190 lines, -0 lines 0 comments Download
M src/lte/doc/source/lte-user.rst View 1 chunk +55 lines, -0 lines 0 comments Download
M src/lte/model/eps-bearer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/lte/model/eps-bearer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A src/lte/model/fdbet-ff-mac-scheduler.h View 1 chunk +212 lines, -0 lines 2 comments Download
A src/lte/model/fdbet-ff-mac-scheduler.cc View 1 chunk +1200 lines, -0 lines 6 comments Download
A src/lte/model/fdmt-ff-mac-scheduler.h View 1 chunk +198 lines, -0 lines 0 comments Download
A src/lte/model/fdmt-ff-mac-scheduler.cc View 1 chunk +1149 lines, -0 lines 0 comments Download
A src/lte/model/fdtbfq-ff-mac-scheduler.h View 1 chunk +234 lines, -0 lines 0 comments Download
A src/lte/model/fdtbfq-ff-mac-scheduler.cc View 1 chunk +1442 lines, -0 lines 0 comments Download
A src/lte/model/pss-ff-mac-scheduler.h View 1 chunk +227 lines, -0 lines 0 comments Download
A src/lte/model/pss-ff-mac-scheduler.cc View 1 chunk +1540 lines, -0 lines 0 comments Download
A src/lte/model/tdbet-ff-mac-scheduler.h View 1 chunk +212 lines, -0 lines 0 comments Download
A src/lte/model/tdbet-ff-mac-scheduler.cc View 1 chunk +1132 lines, -0 lines 0 comments Download
A src/lte/model/tdmt-ff-mac-scheduler.h View 1 chunk +199 lines, -0 lines 0 comments Download
A src/lte/model/tdmt-ff-mac-scheduler.cc View 1 chunk +1096 lines, -0 lines 0 comments Download
A src/lte/model/tdtbfq-ff-mac-scheduler.h View 1 chunk +234 lines, -0 lines 0 comments Download
A src/lte/model/tdtbfq-ff-mac-scheduler.cc View 1 chunk +1240 lines, -0 lines 0 comments Download
A src/lte/model/tta-ff-mac-scheduler.h View 1 chunk +208 lines, -0 lines 0 comments Download
A src/lte/model/tta-ff-mac-scheduler.cc View 1 chunk +1210 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-fdbet-ff-mac-scheduler.h View 1 chunk +89 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-fdbet-ff-mac-scheduler.cc View 1 chunk +529 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-fdmt-ff-mac-scheduler.h View 1 chunk +67 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-fdmt-ff-mac-scheduler.cc View 1 chunk +342 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-fdtbfq-ff-mac-scheduler.h View 1 chunk +90 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-fdtbfq-ff-mac-scheduler.cc View 1 chunk +758 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-pss-ff-mac-scheduler.h View 1 chunk +89 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-pss-ff-mac-scheduler.cc View 1 chunk +785 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-tdbet-ff-mac-scheduler.h View 1 chunk +89 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-tdbet-ff-mac-scheduler.cc View 1 chunk +547 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-tdmt-ff-mac-scheduler.h View 1 chunk +67 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-tdmt-ff-mac-scheduler.cc View 1 chunk +342 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.h View 1 chunk +90 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-tdtbfq-ff-mac-scheduler.cc View 1 chunk +754 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-tta-ff-mac-scheduler.h View 1 chunk +66 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-tta-ff-mac-scheduler.cc View 1 chunk +342 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Tom Henderson
I scanned through this code (it is a lot of code) again tonight. This is ...
9 years, 8 months ago (2012-10-29 05:33:47 UTC) #1
Dizhi.Zhou
9 years, 7 months ago (2012-11-30 22:43:06 UTC) #2
Hi Tom,

I update GSoC codes based on your comment. Please find detail below. The new
version has already push to repository:
http://code.nsnam.org/dizhizhou/ns-3-dev

Best regards
Dizhi

https://codereview.appspot.com/6591047/diff/1/src/lte/doc/source/lte-design.rst
File src/lte/doc/source/lte-design.rst (right):

https://codereview.appspot.com/6591047/diff/1/src/lte/doc/source/lte-design.r...
src/lte/doc/source/lte-design.rst:659: Currently, MT scheduler in LENA has two
versions: frequency domain (FDMT) and time domain (TDMT).
On 2012/10/29 05:33:47, Tom Henderson wrote:
> ns-3 instead of LENA?

Done.

https://codereview.appspot.com/6591047/diff/1/src/lte/doc/source/lte-design.r...
src/lte/doc/source/lte-design.rst:734: Token Band Fair Queue (TBFQ) is a QoS
aware scheduler which derives from the leaky-bucket mechanism. In TBFQ,
On 2012/10/29 05:33:47, Tom Henderson wrote:
> Token Bank

Done.

https://codereview.appspot.com/6591047/diff/1/src/lte/doc/source/lte-referenc...
File src/lte/doc/source/lte-references.rst (right):

https://codereview.appspot.com/6591047/diff/1/src/lte/doc/source/lte-referenc...
src/lte/doc/source/lte-references.rst:88: .. [FCapo2012] F.Capozzi, G.Piro
L.A.Grieco, G.Boggia, P.Camarda, "Downlink Packet Scheduling in LTE Cellular
Networks: Key Design Issues and a Survey", IEEE Comm. Surveys and Tutorials, to
appear
On 2012/10/29 05:33:47, Tom Henderson wrote:
> this seems to be now published in issue 99

Done.

https://codereview.appspot.com/6591047/diff/1/src/lte/model/fdbet-ff-mac-sche...
File src/lte/model/fdbet-ff-mac-scheduler.cc (right):

https://codereview.appspot.com/6591047/diff/1/src/lte/model/fdbet-ff-mac-sche...
src/lte/model/fdbet-ff-mac-scheduler.cc:25: #endif /* __FreeBSD__ */
I updated GSoC code to NS-3.15 in Oct.21. These code were removed in the latest
version.

On 2012/10/29 05:33:47, Tom Henderson wrote:
> This probably needs to be moved to proposed math.h; see bug 1467

https://codereview.appspot.com/6591047/diff/1/src/lte/model/fdbet-ff-mac-sche...
src/lte/model/fdbet-ff-mac-scheduler.cc:351: // TODO: Implementation of the API
Change to following codes:
NS_FATAL_ERROR ("unimplemented"):
return;

Hi Tome, do you think we also need to show the API's name in NS_FATAL_ERROR? In
this way, user can locate which API they incorrectly used.
On 2012/10/29 05:33:47, Tom Henderson wrote:
> Consider instead to make this, and all such "TODOs", throw an NS_FATAL_ERROR
> ("Unimplemented").

https://codereview.appspot.com/6591047/diff/1/src/lte/model/fdbet-ff-mac-sche...
src/lte/model/fdbet-ff-mac-scheduler.cc:1005: //NS_LOG_DEBUG (this << " Does not
find info on allocation, size : " << m_allocationMaps.size ());
On 2012/10/29 05:33:47, Tom Henderson wrote:
> delete commented out log statements, or uncomment

Done.

https://codereview.appspot.com/6591047/diff/1/src/lte/model/fdbet-ff-mac-sche...
File src/lte/model/fdbet-ff-mac-scheduler.h (right):

https://codereview.appspot.com/6591047/diff/1/src/lte/model/fdbet-ff-mac-sche...
src/lte/model/fdbet-ff-mac-scheduler.h:90: // (See 4.1 for description of the
primitives)
This is the "LTE MAC Scheduler Interface Specification 1.1". It is explained in
In LTE manual.
On 2012/10/29 05:33:47, Tom Henderson wrote:
> 4.1 of what?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b