Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1628)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Unified Diff: src/cmd/ld/lib.h
Issue
6572043
:
code review 6572043: reflect: add ArrayOf, ChanOf, MapOf, SliceOf (Closed)
Patch Set: diff -r 6e9d872ffc66 https://code.google.com/p/go/
Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
src/cmd/gc/go.h
src/cmd/gc/lex.c
src/cmd/gc/reflect.c
src/cmd/ld/data.c
src/cmd/ld/decodesym.c
src/cmd/ld/dwarf.c
src/cmd/ld/go.c
src/cmd/ld/lib.h
src/cmd/ld/symtab.c
src/pkg/reflect/all_test.go
src/pkg/reflect/export_test.go
src/pkg/reflect/makefunc.go
src/pkg/reflect/type.go
src/pkg/reflect/value.go
src/pkg/runtime/iface.c
src/pkg/runtime/runtime-gdb.py
src/pkg/runtime/type.h
src/pkg/runtime/type.go
src/pkg/runtime/typekind.h
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« src/cmd/ld/go.c
('k') |
src/cmd/ld/symtab.c »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: src/cmd/ld/lib.h
===================================================================
--- a/src/cmd/ld/lib.h
+++ b/src/cmd/ld/lib.h
@@ -39,6 +39,7 @@
SSTRING,
SGOSTRING,
SRODATA,
+ STYPELINK,
SGCDATA,
SGCBSS,
SSYMTAB,
« no previous file with comments
|
« src/cmd/ld/go.c
('k') |
src/cmd/ld/symtab.c »
('j') |
no next file with comments »
Issue 6572043: code review 6572043: reflect: add ArrayOf, ChanOf, MapOf, SliceOf (Closed)
Created 11 years, 6 months ago by rsc
Modified 11 years, 4 months ago
Reviewers:
Base URL:
Comments: 51
Recent Issues
|
This issue
This is Rietveld
f62528b