Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(369)

Issue 6570043: state: drop error result from Unit.Resolved

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by niemeyer
Modified:
11 years, 7 months ago
Reviewers:
mp+126110
Visibility:
Public.

Description

state: drop error result from Unit.Resolved https://code.launchpad.net/~niemeyer/juju-core/drop-resolved-error-result/+merge/126110 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: drop error result from Unit.Resolved #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/unit.go View 1 chunk +2 lines, -2 lines 0 comments Download
M state/unit_test.go View 1 chunk +14 lines, -8 lines 0 comments Download

Messages

Total messages: 3
niemeyer
Please take a look.
11 years, 7 months ago (2012-09-24 21:41:03 UTC) #1
niemeyer
<fwereade> niemeyer, LGTM, much nicer
11 years, 7 months ago (2012-09-24 22:44:01 UTC) #2
niemeyer
11 years, 7 months ago (2012-09-24 22:47:15 UTC) #3
*** Submitted:

state: drop error result from Unit.Resolved

R=
CC=
https://codereview.appspot.com/6570043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b