Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(474)

Unified Diff: environs/ec2/live_test.go

Issue 6567048: environs/ec2: several live tests fixes
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: environs/ec2/live_test.go
=== modified file 'environs/ec2/live_test.go'
--- environs/ec2/live_test.go 2012-09-06 14:54:50 +0000
+++ environs/ec2/live_test.go 2012-09-26 02:22:30 +0000
@@ -99,20 +99,23 @@
t.LoggingSuite.TearDownTest(c)
}
+// TODO(niemeyer): Looks like many of those tests should be moved to jujutest.LiveTests.
+
func (t *LiveTests) TestInstanceDNSName(c *C) {
inst, err := t.Env.StartInstance(30, jujutest.InvalidStateInfo, nil)
c.Assert(err, IsNil)
defer t.Env.StopInstances([]environs.Instance{inst})
dns, err := inst.WaitDNSName()
- c.Check(err, IsNil)
- c.Check(dns, Not(Equals), "")
+ // TODO(niemeyer): This assert sometimes fails with "no instances found"
+ c.Assert(err, IsNil)
+ c.Assert(dns, Not(Equals), "")
dfc 2012/09/26 05:11:20 LGTM. I wonder why someone thought they should use
insts, err := t.Env.Instances([]string{inst.Id()})
c.Assert(err, IsNil)
c.Assert(len(insts), Equals, 1)
ec2inst := ec2.InstanceEC2(insts[0])
- c.Check(ec2inst.DNSName, Equals, dns)
+ c.Assert(ec2inst.DNSName, Equals, dns)
}
func (t *LiveTests) TestInstanceGroups(c *C) {

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b