Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(596)

Issue 6566059: Ninja --generator-output to match other generators. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by bungeman of chrome
Modified:
1 year, 6 months ago
Reviewers:
bungeman, thakis
CC:
gyp-developer_googlegroups.com
Base URL:
http://gyp.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Ninja --generator-output to match other generators.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix absolute path handling as well. #

Patch Set 3 : Works with Tests and Skia. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M pylib/gyp/generator/ninja.py View 1 2 2 chunks +9 lines, -5 lines 2 comments Download

Messages

Total messages: 11
bungeman of chrome
This grew out of some discussion at https://codereview.appspot.com/6455075/ . This change allows Skia to build ...
1 year, 6 months ago #1
thakis
Thanks! https://codereview.appspot.com/6566059/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://codereview.appspot.com/6566059/diff/1/pylib/gyp/generator/ninja.py#newcode1306 pylib/gyp/generator/ninja.py:1306: config_name)) What's the error message if generator-output is ...
1 year, 6 months ago #2
bungeman of chrome
With Patch Set 2, Skia's gyp_skia needs no modification to run the ninja generator. This ...
1 year, 6 months ago #3
thakis
lgtm
1 year, 6 months ago #4
bungeman
Unfortunately, this is breaking a test.
1 year, 6 months ago #5
thakis
On 2012/09/29 00:16:11, bungeman wrote: > Unfortunately, this is breaking a test. (You can run ...
1 year, 6 months ago #6
bungeman of chrome
Patch Set 2 was breaking toplevel-tests (where top-level=..). I believe Patch Set 3 addresses this ...
1 year, 6 months ago #7
thakis
lgtm Do you need me to land this? Can you send tryjobs? https://codereview.appspot.com/6566059/diff/9001/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py ...
1 year, 6 months ago #8
bungeman of chrome
I can commit. I didn't start this CL with gcl, so I'm not sure if ...
1 year, 6 months ago #9
thakis
On 2012/10/02 05:51:48, bungeman of chrome wrote: > I can commit. I didn't start this ...
1 year, 6 months ago #10
bungeman of chrome
1 year, 6 months ago #11
Committed revision 1509.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5