Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 6566059: Ninja --generator-output to match other generators. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by bungeman of chrome
Modified:
2 years, 9 months ago
Reviewers:
bungeman, thakis
CC:
gyp-developer_googlegroups.com
Base URL:
http://gyp.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Ninja --generator-output to match other generators.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix absolute path handling as well. #

Patch Set 3 : Works with Tests and Skia. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M pylib/gyp/generator/ninja.py View 1 2 2 chunks +9 lines, -5 lines 2 comments Download

Messages

Total messages: 11
bungeman of chrome
This grew out of some discussion at https://codereview.appspot.com/6455075/ . This change allows Skia to build ...
2 years, 9 months ago (2012-09-27 06:05:18 UTC) #1
thakis
Thanks! https://codereview.appspot.com/6566059/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): https://codereview.appspot.com/6566059/diff/1/pylib/gyp/generator/ninja.py#newcode1306 pylib/gyp/generator/ninja.py:1306: config_name)) What's the error message if generator-output is ...
2 years, 9 months ago (2012-09-27 06:28:09 UTC) #2
bungeman of chrome
With Patch Set 2, Skia's gyp_skia needs no modification to run the ninja generator. This ...
2 years, 9 months ago (2012-09-27 14:41:11 UTC) #3
thakis
lgtm
2 years, 9 months ago (2012-09-28 04:01:13 UTC) #4
bungeman
Unfortunately, this is breaking a test.
2 years, 9 months ago (2012-09-29 00:16:11 UTC) #5
thakis
On 2012/09/29 00:16:11, bungeman wrote: > Unfortunately, this is breaking a test. (You can run ...
2 years, 9 months ago (2012-09-29 11:40:53 UTC) #6
bungeman of chrome
Patch Set 2 was breaking toplevel-tests (where top-level=..). I believe Patch Set 3 addresses this ...
2 years, 9 months ago (2012-10-02 05:29:49 UTC) #7
thakis
lgtm Do you need me to land this? Can you send tryjobs? https://codereview.appspot.com/6566059/diff/9001/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py ...
2 years, 9 months ago (2012-10-02 05:32:47 UTC) #8
bungeman of chrome
I can commit. I didn't start this CL with gcl, so I'm not sure if ...
2 years, 9 months ago (2012-10-02 05:51:48 UTC) #9
thakis
On 2012/10/02 05:51:48, bungeman of chrome wrote: > I can commit. I didn't start this ...
2 years, 9 months ago (2012-10-02 05:56:16 UTC) #10
bungeman of chrome
2 years, 9 months ago (2012-10-02 06:19:05 UTC) #11
Committed revision 1509.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5