Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27)

Issue 6565056: code review 6565056: bufio: Implement io.ReaderFrom for (*Writer). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by chaten
Modified:
9 years, 7 months ago
Reviewers:
CC:
nigeltao, golang-dev
Visibility:
Public.

Description

bufio: Implement io.ReaderFrom for (*Writer). This is part 2 of 2 for issue 4028. benchmark old ns/op new ns/op delta BenchmarkWriterCopyOptimal 53293 28326 -46.85% BenchmarkWriterCopyUnoptimal 53757 30537 -43.19% BenchmarkWriterCopyNoReadFrom 53192 36642 -31.11% Fixes issue 4028.

Patch Set 1 #

Patch Set 2 : diff -r 8e69b6243f49 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 8e69b6243f49 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 4 : diff -r 8e69b6243f49 https://code.google.com/p/go/ #

Total comments: 5

Patch Set 5 : diff -r 9b2c48c9d597 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 6 : diff -r 9b2c48c9d597 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -3 lines) Patch
M src/pkg/bufio/bufio.go View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
M src/pkg/bufio/bufio_test.go View 1 2 3 4 4 chunks +98 lines, -3 lines 0 comments Download

Messages

Total messages: 12
chaten
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 9 months ago (2012-09-27 09:27:00 UTC) #1
nigeltao
https://codereview.appspot.com/6565056/diff/5001/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): https://codereview.appspot.com/6565056/diff/5001/src/pkg/bufio/bufio.go#newcode582 src/pkg/bufio/bufio.go:582: for m, err = b.readBuf(r); m > 0 && ...
9 years, 9 months ago (2012-09-28 04:49:24 UTC) #2
chaten
https://codereview.appspot.com/6565056/diff/5001/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): https://codereview.appspot.com/6565056/diff/5001/src/pkg/bufio/bufio.go#newcode582 src/pkg/bufio/bufio.go:582: for m, err = b.readBuf(r); m > 0 && ...
9 years, 9 months ago (2012-09-28 06:12:08 UTC) #3
chaten
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-09-28 06:12:33 UTC) #4
chaten
https://codereview.appspot.com/6565056/diff/9001/src/pkg/bufio/bufio_test.go File src/pkg/bufio/bufio_test.go (right): https://codereview.appspot.com/6565056/diff/9001/src/pkg/bufio/bufio_test.go#newcode782 src/pkg/bufio/bufio_test.go:782: r := NewReader(&onlyReader{bytes.NewBuffer(input)}) I made this change to make ...
9 years, 9 months ago (2012-09-28 06:15:32 UTC) #5
nigeltao
http://codereview.appspot.com/6565056/diff/9001/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): http://codereview.appspot.com/6565056/diff/9001/src/pkg/bufio/bufio.go#newcode581 src/pkg/bufio/bufio.go:581: var n, m int64 You could delete some of ...
9 years, 9 months ago (2012-10-04 12:34:46 UTC) #6
chaten
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2012-10-18 06:16:04 UTC) #7
nigeltao
https://codereview.appspot.com/6565056/diff/13001/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): https://codereview.appspot.com/6565056/diff/13001/src/pkg/bufio/bufio.go#newcode599 src/pkg/bufio/bufio.go:599: func (b *Writer) readBuf(r io.Reader) (int64, error) { Delete ...
9 years, 8 months ago (2012-10-18 06:25:11 UTC) #8
chaten
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2012-10-18 08:02:24 UTC) #9
nigeltao
LGTM.
9 years, 8 months ago (2012-10-19 00:20:46 UTC) #10
nigeltao
*** Submitted as http://code.google.com/p/go/source/detail?r=d0ca00912d1c *** bufio: Implement io.ReaderFrom for (*Writer). This is part 2 of ...
9 years, 8 months ago (2012-10-19 00:23:32 UTC) #11
chaten
9 years, 7 months ago (2012-11-20 22:00:40 UTC) #12
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b