Issue 65550043: Promulgate bundles owned by ~charmers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 65550043: Promulgate bundles owned by ~charmers.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by bac

Modified:
10 years, 2 months ago

Reviewers:
mp+207016, benji-york

Visibility:
Public.

Description

Promulgate bundles owned by ~charmers. https://code.launchpad.net/~bac/charmworld/promulgate-bundles/+merge/207016 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -19 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charmworld/forms/featured.py	View	1 chunk	+18 lines, -2 lines	0 comments	Download
M	charmworld/jobs/ingest.py	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	charmworld/jobs/lp.py	View	1 chunk	+3 lines, -2 lines	1 comment	Download
M	charmworld/jobs/tests/test_ingest.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	charmworld/jobs/tests/test_lp.py	View	1 chunk	+10 lines, -1 line	1 comment	Download
M	charmworld/jobs/utils.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	charmworld/models.py	View	4 chunks	+7 lines, -3 lines	0 comments	Download
A	charmworld/tests/test_forms.py	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	charmworld/tests/test_models.py	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	charmworld/views/featured.py	View	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bac

https://codereview.appspot.com/65550043/diff/1/charmworld/jobs/tests/test_lp.py File charmworld/jobs/tests/test_lp.py (right): https://codereview.appspot.com/65550043/diff/1/charmworld/jobs/tests/test_lp.py#newcode177 charmworld/jobs/tests/test_lp.py:177: # is not used to determine whether a bundle ...

10 years, 2 months ago (2014-02-18 19:24:20 UTC) #2

benji-york

10 years, 2 months ago (2014-02-18 19:32:38 UTC) #3

LGTM

https://codereview.appspot.com/65550043/diff/1/charmworld/jobs/lp.py
File charmworld/jobs/lp.py (right):

https://codereview.appspot.com/65550043/diff/1/charmworld/jobs/lp.py#newcode70
charmworld/jobs/lp.py:70: 
Some prose describing the fact that the first "data['promulgated'] =" is for
bundles only and the second is for charms only would be nice.  It took me a
while to figure that out.

Expand All Messages | Collapse All Messages