Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(287)

Issue 6552061: code review 6552061: cmd/5g: fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by minux
Modified:
1 year, 7 months ago
Reviewers:
rsc
CC:
r, golang-dev
Visibility:
Public.

Description

cmd/5g: fix build

Patch Set 1 #

Patch Set 2 : diff -r 99fee67bd747 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 99fee67bd747 https://code.google.com/p/go/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/5g/cgen.c View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8
minux
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
1 year, 7 months ago #1
r
LGTM
1 year, 7 months ago #2
minux
*** Submitted as http://code.google.com/p/go/source/detail?r=bbb1a6dfcd58 *** cmd/5g: fix build R=rsc, r CC=golang-dev http://codereview.appspot.com/6552061
1 year, 7 months ago #3
rsc
http://codereview.appspot.com/6552061/diff/8001/src/cmd/5g/cgen.c File src/cmd/5g/cgen.c (right): http://codereview.appspot.com/6552061/diff/8001/src/cmd/5g/cgen.c#newcode565 src/cmd/5g/cgen.c:565: gins(AMOVW, &n1, &n2); Apologies for breaking the build. However, ...
1 year, 7 months ago #4
minux
On Tuesday, September 25, 2012, rsc wrote: > > http://codereview.appspot.com/**6552061/diff/8001/src/cmd/5g/** > cgen.c#newcode565<http://codereview.appspot.com/6552061/diff/8001/src/cmd/5g/cgen.c#newcode565> > src/cmd/5g/cgen.c:565: gins(AMOVW, ...
1 year, 7 months ago #5
rsc
> I thought it shouldn't be that simple too, but the test you introduced in ...
1 year, 7 months ago #6
minux
On Tuesday, September 25, 2012, minux wrote: > > Maybe that problem just doesn't occur ...
1 year, 7 months ago #7
rsc
1 year, 7 months ago #8
> On Tuesday, September 25, 2012, minux wrote:
>>
>> Maybe that problem just doesn't occur on arm?
>
> Really strange, I reverted that CL, and bug444.go still run without panic.

Probably 5g never gets there for that case. Exactly when agen gets
called may vary from compiler to compiler.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5