code review 6551059: cmd/gc: fix escape analysis bug

cmd/gc: fix escape analysis bug

Was not handling &x.y[0] and &x.y.z correctly where
y is an array or struct-valued field (not a pointer).

[rsc, 2012-09-24 19:53:11]

Hello ken2 (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-09-24 19:53:16]

*** Submitted as http://code.google.com/p/go/source/detail?r=0ece4ff29314 ***

cmd/gc: fix escape analysis bug

Was not handling &x.y[0] and &x.y.z correctly where
y is an array or struct-valued field (not a pointer).

R=ken2
CC=golang-dev
http://codereview.appspot.com/6551059

[ken3, 2012-09-24 20:01:27]

lgtm

[remyoudompheng, 2012-09-24 20:10:23]

I suppose the bug is present in Go 1.0.3 ?

[rsc, 2012-09-24 21:30:53]

On Mon, Sep 24, 2012 at 4:10 PM, Rémy Oudompheng
<remyoudompheng@gmail.com> wrote:
> I suppose the bug is present in Go 1.0.3 ?

Yes but as far as I know no one has run into it. It is somewhat
compensated for by the fact that &T{} is always treated as escaping
and by the fact that most programs do not allocate a big struct and
then return only a pointer to a piece of it. If we do a Go 1.0.4 we'd
want to include it, but I hope we won't do that.

Russ