Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1211)

Issue 6551043: Sort map keys.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by niemeyer
Modified:
11 years, 7 months ago
Reviewers:
mp+125431, dave
Visibility:
Public.

Description

Sort map keys. https://code.launchpad.net/~niemeyer/goyaml/stable-maps/+merge/125431 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Sort map keys. #

Patch Set 3 : Sort map keys. #

Patch Set 4 : Sort map keys. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -2 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M encode.go View 2 chunks +4 lines, -1 line 0 comments Download
M encode_test.go View 1 2 2 chunks +68 lines, -1 line 0 comments Download
A sorter.go View 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 5
niemeyer
Please take a look.
11 years, 7 months ago (2012-09-20 09:01:43 UTC) #1
niemeyer
Please take a look.
11 years, 7 months ago (2012-09-20 09:27:44 UTC) #2
niemeyer
Please take a look.
11 years, 7 months ago (2012-09-20 09:33:56 UTC) #3
dave_cheney.net
On 2012/09/20 09:33:56, niemeyer wrote: > Please take a look. LGTM. Thank you.
11 years, 7 months ago (2012-09-20 09:35:30 UTC) #4
niemeyer
11 years, 7 months ago (2012-09-20 09:42:12 UTC) #5
*** Submitted:

Sort map keys.

R=dfc
CC=
https://codereview.appspot.com/6551043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b