Issue 6549051: protect zookeeper from non-root direct access

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6549051: protect zookeeper from non-root direct access

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by clint.byrum

Modified:
11 years, 6 months ago

Reviewers:
hazmat, mp+125832

Visibility:
Public.

Description

protect zookeeper from non-root direct access Adds pre-start capability to juju.lib.upstart. Also reformatted tests' cloud-config data to be more readable. https://code.launchpad.net/~clint-fewbar/juju/add-egress-zookeeper-protection/+merge/125832 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+498 lines, -461 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	juju/lib/tests/data/test_prestart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	juju/lib/tests/test_upstart.py	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	juju/lib/upstart.py	View	4 chunks	+6 lines, -1 line	0 comments	Download
M	juju/providers/common/cloudinit.py	View	2 chunks	+43 lines, -0 lines	0 comments	Download
M	juju/providers/common/tests/data/cloud_init_bootstrap	View	1 chunk	+33 lines, -52 lines	0 comments	Download
M	juju/providers/common/tests/data/cloud_init_bootstrap_zookeepers	View	1 chunk	+45 lines, -52 lines	0 comments	Download
M	juju/providers/common/tests/data/cloud_init_branch	View	1 chunk	+34 lines, -29 lines	0 comments	Download
M	juju/providers/common/tests/data/cloud_init_branch_trunk	View	1 chunk	+34 lines, -29 lines	0 comments	Download
M	juju/providers/common/tests/data/cloud_init_distro	View	1 chunk	+30 lines, -27 lines	0 comments	Download
M	juju/providers/common/tests/data/cloud_init_ppa	View	1 chunk	+30 lines, -27 lines	0 comments	Download
M	juju/providers/common/tests/data/cloud_init_proposed	View	1 chunk	+30 lines, -27 lines	0 comments	Download
M	juju/providers/ec2/tests/data/bootstrap_cloud_init	View	1 chunk	+33 lines, -53 lines	0 comments	Download
M	juju/providers/ec2/tests/data/launch_cloud_init	View	1 chunk	+29 lines, -27 lines	0 comments	Download
M	juju/providers/ec2/tests/data/launch_cloud_init_branch	View	1 chunk	+33 lines, -29 lines	0 comments	Download
M	juju/providers/ec2/tests/data/launch_cloud_init_ppa	View	1 chunk	+29 lines, -27 lines	0 comments	Download
M	juju/providers/orchestra/launch.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/providers/orchestra/tests/data/bootstrap_user_data	View	1 chunk	+33 lines, -53 lines	0 comments	Download
M	juju/providers/orchestra/tests/data/launch_user_data	View	1 chunk	+29 lines, -27 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hazmat

11 years, 6 months ago (2012-09-27 06:02:43 UTC) #2

cool. i'll have to brush on my iptables syntax. does the impl here support
service restarts?

Expand All Messages | Collapse All Messages