Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(999)

Issue 6532053: code review 6532053: misc/vim: fix Drop for imports after the first group. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dsymonds
Modified:
11 years, 7 months ago
Reviewers:
CC:
golang-dev, fss
Visibility:
Public.

Description

misc/vim: fix Drop for imports after the first group. Previously, an import block such as import ( "net" "stack" ) would not permit ":Drop stack" to work because we were aborting the scan early, which is only correct when Import is in operation.

Patch Set 1 #

Patch Set 2 : diff -r b7ce1e467a60 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b0c749cc5654 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 998714a0082d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -14 lines) Patch
M misc/vim/ftplugin/go/import.vim View 1 1 chunk +1 line, -1 line 0 comments Download
M misc/vim/ftplugin/go/test.sh View 1 2 1 chunk +30 lines, -13 lines 0 comments Download

Messages

Total messages: 3
dsymonds
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 7 months ago (2012-09-19 13:33:42 UTC) #1
fss
LGTM
11 years, 7 months ago (2012-09-19 17:42:02 UTC) #2
dsymonds
11 years, 7 months ago (2012-09-19 22:11:16 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=b5b922479280 ***

misc/vim: fix Drop for imports after the first group.

Previously, an import block such as
	import (
        	"net"

                "stack"
        )
would not permit ":Drop stack" to work because we were aborting
the scan early, which is only correct when Import is in operation.

R=golang-dev, franciscossouza
CC=golang-dev
http://codereview.appspot.com/6532053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b