Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(618)

Issue 6506120: code review 6506120: text/template: fix typo of errorf as error in comment. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by jshholland
Modified:
1 year, 6 months ago
Reviewers:
CC:
r, minux, gobot, golang-dev
Visibility:
Public.

Description

text/template: fix typo of errorf as error in comment.

Patch Set 1 #

Patch Set 2 : diff -r e990cf183236 https://code.google.com/p/go/ #

Patch Set 3 : diff -r e990cf183236 https://code.google.com/p/go/ #

Patch Set 4 : diff -r e990cf183236 https://code.google.com/p/go/ #

Total comments: 6

Patch Set 5 : diff -r e990cf183236 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 44b9f2d5eb03 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M src/pkg/text/template/parse/lex.go View 1 2 3 4 5 8 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 14
jshholland
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
1 year, 7 months ago #1
jshholland
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 7 months ago #2
gobot
R=r (assigned by dsymonds)
1 year, 7 months ago #3
r
Thanks for the careful scan but let's tweak a little. http://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/lex.go File src/pkg/text/template/parse/lex.go (right): http://codereview.appspot.com/6506120/diff/5001/src/pkg/text/template/parse/lex.go#newcode18 ...
1 year, 7 months ago #4
jshholland
Hello r@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com), Please take another look.
1 year, 7 months ago #5
jshholland
PTAL. To confirm, the rule is caps and full stop iff the comment is a ...
1 year, 7 months ago #6
r
this is good but you'll need to sync and upload.
1 year, 7 months ago #7
r
You'll also need to fill in the CLA as described at http://golang.org/doc/contribute.html#copyright -rob
1 year, 7 months ago #8
jshholland
I have done "hg sync", followed by "hg change 6506120". I believe this is correct. ...
1 year, 7 months ago #9
jshholland
Hello r@golang.org (cc: gobot@golang.org, golang-dev@googlegroups.com), Please take another look.
1 year, 7 months ago #10
jshholland
On 2012/09/24 16:46:05, jshholland wrote: > Hello mailto:r@golang.org (cc: mailto:gobot@golang.org, mailto:golang-dev@googlegroups.com), > > Please take ...
1 year, 7 months ago #11
minux
On Tuesday, September 25, 2012, wrote: > > I accidentally deleted a line; this puts ...
1 year, 7 months ago #12
r
LGTM
1 year, 6 months ago #13
r
1 year, 6 months ago #14
*** Submitted as http://code.google.com/p/go/source/detail?r=820619c4c27b ***

text/template: fix typo of errorf as error in comment.

R=r, minux.ma
CC=gobot, golang-dev
http://codereview.appspot.com/6506120

Committer: Rob Pike <r@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5