Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1306)

Issue 6506113: code review 6506113: go-playground: fix for FireFox, remove traces of codemi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by adg
Modified:
11 years, 6 months ago
Reviewers:
CC:
golang-dev, fss, rsc
Visibility:
Public.

Description

go-playground: fix for FireFox, remove traces of codemirror, disable spellcheck

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r ef1a855f7160 https://code.google.com/p/go-playground #

Patch Set 3 : diff -r ef1a855f7160 https://code.google.com/p/go-playground #

Patch Set 4 : diff -r ef1a855f7160 https://code.google.com/p/go-playground #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -24 lines) Patch
M goplay/edit.html View 1 2 2 chunks +11 lines, -10 lines 0 comments Download
M static/style.css View 1 2 chunks +31 lines, -14 lines 0 comments Download

Messages

Total messages: 7
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-playground
11 years, 6 months ago (2012-09-13 22:40:28 UTC) #1
fss
Just one extra </div> living alone. https://codereview.appspot.com/6506113/diff/1/goplay/edit.html File goplay/edit.html (right): https://codereview.appspot.com/6506113/diff/1/goplay/edit.html#newcode34 goplay/edit.html:34: </div> There's no ...
11 years, 6 months ago (2012-09-13 22:57:24 UTC) #2
rsc
LGTM Is there a 'fixes issue' for the firefox thing?
11 years, 6 months ago (2012-09-13 22:59:52 UTC) #3
adg
Hello golang-dev@googlegroups.com, franciscossouza@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 6 months ago (2012-09-13 23:11:24 UTC) #4
adg
On 14 September 2012 08:59, Russ Cox <rsc@golang.org> wrote: > LGTM > > Is there ...
11 years, 6 months ago (2012-09-13 23:12:10 UTC) #5
fss
On 2012/09/13 23:11:24, adg wrote: > Hello mailto:golang-dev@googlegroups.com, mailto:franciscossouza@gmail.com, mailto:rsc@golang.org > (cc: mailto:golang-dev@googlegroups.com), > > ...
11 years, 6 months ago (2012-09-13 23:13:56 UTC) #6
adg
11 years, 6 months ago (2012-09-13 23:24:35 UTC) #7
*** Submitted as
http://code.google.com/p/go-playground/source/detail?r=781fa4f5d565 ***

go-playground: fix for FireFox, remove traces of codemirror, disable spellcheck

R=golang-dev, franciscossouza, rsc
CC=golang-dev
http://codereview.appspot.com/6506113
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b