Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(493)

Issue 6503090: code review 6503090: net/http: add If-None-Match and If-Range support to Ser... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by bradfitz
Modified:
11 years, 6 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

net/http: add If-None-Match and If-Range support to ServeContent Also, clear Content-Type and Content-Length on Not Modified responses before server.go strips them and spams the logs with warnings.

Patch Set 1 #

Patch Set 2 : diff -r d694b1866058 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d694b1866058 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7fa140566591 https://go.googlecode.com/hg/ #

Total comments: 10

Patch Set 5 : diff -r 9e5a84e0fa57 https://go.googlecode.com/hg #

Patch Set 6 : diff -r 9e5a84e0fa57 https://go.googlecode.com/hg #

Patch Set 7 : diff -r 9e5a84e0fa57 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -37 lines) Patch
M src/pkg/net/http/fs.go View 1 2 3 4 5 5 chunks +63 lines, -1 line 0 comments Download
M src/pkg/net/http/fs_test.go View 1 2 3 1 chunk +125 lines, -36 lines 0 comments Download

Messages

Total messages: 6
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 6 months ago (2012-09-07 15:54:31 UTC) #1
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 6 months ago (2012-09-07 21:26:01 UTC) #2
bradfitz
R=Russ, Andrew, ... anybody who likes HTTP? On Fri, Sep 7, 2012 at 2:26 PM, ...
11 years, 6 months ago (2012-09-07 21:52:19 UTC) #3
rsc
LGTM http://codereview.appspot.com/6503090/diff/5001/src/pkg/net/http/fs.go File src/pkg/net/http/fs.go (right): http://codereview.appspot.com/6503090/diff/5001/src/pkg/net/http/fs.go#newcode102 src/pkg/net/http/fs.go:102: // You need something more here about ETags. ...
11 years, 6 months ago (2012-09-10 15:55:53 UTC) #4
bradfitz
https://codereview.appspot.com/6503090/diff/5001/src/pkg/net/http/fs.go File src/pkg/net/http/fs.go (right): https://codereview.appspot.com/6503090/diff/5001/src/pkg/net/http/fs.go#newcode102 src/pkg/net/http/fs.go:102: // On 2012/09/10 15:55:53, rsc wrote: > You need ...
11 years, 6 months ago (2012-09-10 17:09:12 UTC) #5
bradfitz
11 years, 6 months ago (2012-09-10 17:16:12 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=67b66dd9ea4a ***

net/http: add If-None-Match and If-Range support to ServeContent

Also, clear Content-Type and Content-Length on Not Modified
responses before server.go strips them and spams the logs with
warnings.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6503090
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b