Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1653)

Issue 6501117: ec2test: allow an empty user id in AuthorizeSecurityGroupIngress.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by rog
Modified:
10 years, 3 months ago
Reviewers:
mp+123751
Visibility:
Public.

Description

ec2test: allow an empty user id in AuthorizeSecurityGroupIngress. ec2 itself allows it (despite what the documentation says). We also test this live (by removing OwnerId in the source group spec because we're not too concerned about the rare case of a specified owner id) and fix a couple of live tests. https://code.launchpad.net/~rogpeppe/goamz/trunk/+merge/123751 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : ec2test: allow an empty user id in AuthorizeSecurityGroupIngress. #

Patch Set 3 : ec2test: allow an empty user id in AuthorizeSecurityGroupIngress. #

Patch Set 4 : ec2test: allow an empty user id in AuthorizeSecurityGroupIngress. #

Patch Set 5 : ec2test: allow an empty user id in AuthorizeSecurityGroupIngress. #

Patch Set 6 : ec2test: allow an empty user id in AuthorizeSecurityGroupIngress. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -15 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ec2/ec2i_test.go View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M ec2/ec2t_test.go View 1 2 3 4 7 chunks +17 lines, -8 lines 0 comments Download
M ec2/ec2test/server.go View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6
rog
Please take a look.
10 years, 3 months ago (2012-09-11 14:11:00 UTC) #1
niemeyer
LGTM if it reflects reality.
10 years, 3 months ago (2012-09-11 14:16:17 UTC) #2
rog
Please take a look.
10 years, 3 months ago (2012-09-11 14:59:03 UTC) #3
rog
Please take a look.
10 years, 3 months ago (2012-09-11 15:03:15 UTC) #4
niemeyer
Still LGTM
10 years, 3 months ago (2012-09-11 17:34:25 UTC) #5
rog
10 years, 3 months ago (2012-09-11 17:39:07 UTC) #6
*** Submitted:

ec2test: allow an empty user id in AuthorizeSecurityGroupIngress.

ec2 itself allows it (despite what the documentation says).

We also test this live (by removing OwnerId in the source group spec
because we're not too concerned about the rare case of a specified owner id)
and fix a couple of live tests.

R=niemeyer
CC=
https://codereview.appspot.com/6501117
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b