Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(169)

Issue 6501099: code review 6501099: runtime: arm: abort if VFPv3 support missing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by dfc
Modified:
9 years, 8 months ago
Reviewers:
CC:
minux1, rsc, ajstarks, golang-dev
Visibility:
Public.

Description

runtime: arm: abort if VFPv3 support missing Fixes issue 3456. This proposal is a reformulation of CL 5987063. This CL resets the default GOARM value to 6 and allows the use of the VFPv3 optimisation if GOARM=7. Binaries built with this CL in place will abort if GOARM=7 was used and the target host does not support VFPv3.

Patch Set 1 #

Patch Set 2 : diff -r e4b20018f797 https://code.google.com/p/go #

Patch Set 3 : diff -r e4b20018f797 https://code.google.com/p/go #

Patch Set 4 : diff -r e4b20018f797 https://code.google.com/p/go #

Patch Set 5 : diff -r e4b20018f797 https://code.google.com/p/go #

Patch Set 6 : diff -r e4b20018f797 https://code.google.com/p/go #

Total comments: 8

Patch Set 7 : diff -r e990cf183236 https://code.google.com/p/go #

Patch Set 8 : diff -r e990cf183236 https://code.google.com/p/go #

Patch Set 9 : diff -r b7ce1e467a60 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M src/cmd/5l/asm.c View 1 2 3 4 5 6 2 chunks +6 lines, -1 line 0 comments Download
M src/cmd/5l/l.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/5l/obj.c View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/signal_linux_arm.c View 1 2 3 4 5 6 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9
dfc
Hello minux.ma@gmail.com, rsc@golang.org, ajstarks@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2012-09-07 11:01:02 UTC) #1
ajstarks
Tested with the raspberry pi: (Raspbian distro, hardware float) pi@pi ~/go/src/pkg/runtime $ uname -a Linux ...
9 years, 8 months ago (2012-09-08 06:15:43 UTC) #2
dfc
ping
9 years, 8 months ago (2012-09-11 23:08:25 UTC) #3
minux1
LGTM with some minor comment suggestions. sorry for the late review. http://codereview.appspot.com/6501099/diff/7/src/cmd/5l/asm.c File src/cmd/5l/asm.c (right): ...
9 years, 8 months ago (2012-09-16 08:04:18 UTC) #4
dfc
Thank you very much for your comments. PTAL. http://codereview.appspot.com/6501099/diff/7/src/cmd/5l/asm.c File src/cmd/5l/asm.c (right): http://codereview.appspot.com/6501099/diff/7/src/cmd/5l/asm.c#newcode2228 src/cmd/5l/asm.c:2228: // ...
9 years, 8 months ago (2012-09-16 15:05:50 UTC) #5
dfc
Hello minux.ma@gmail.com, rsc@golang.org, ajstarks@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2012-09-16 15:05:59 UTC) #6
minux1
LGTM, please wait for rsc.
9 years, 8 months ago (2012-09-16 17:05:37 UTC) #7
rsc
LGTM
9 years, 8 months ago (2012-09-17 21:13:17 UTC) #8
dfc
9 years, 8 months ago (2012-09-17 23:55:16 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=bfad57cc7171 ***

runtime: arm: abort if VFPv3 support missing

Fixes issue 3456.

This proposal is a reformulation of CL 5987063. This CL resets
the default GOARM value to 6 and allows the use of the VFPv3
optimisation if GOARM=7. Binaries built with this CL in place
will abort if GOARM=7 was used and the target host does not
support VFPv3.

R=minux.ma, rsc, ajstarks
CC=golang-dev
http://codereview.appspot.com/6501099
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b