Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1192)

Issue 6499051: Clear SkCanvas::fLastDeviceToGainFocus when releasing a device (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by bsalomon
Modified:
11 years, 7 months ago
Reviewers:
reed1
CC:
Stephen White, skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : improve comment #

Patch Set 3 : even better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/core/SkCanvas.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4
bsalomon
When a new device is created at the same address as a deleted device, and ...
11 years, 7 months ago (2012-08-29 19:07:03 UTC) #1
bsalomon
Now with a clearer(?) comment.
11 years, 7 months ago (2012-08-29 19:32:32 UTC) #2
reed1
reads like a book. lgtm possibly could sketch out a unittest in the comment: savelayer ...
11 years, 7 months ago (2012-08-29 19:35:18 UTC) #3
bsalomon
11 years, 7 months ago (2012-08-29 19:42:44 UTC) #4
Committed as r5338 (with expanded edition example comment, bloopers, and
outtakes).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b