Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1711)

Issue 6497046: Add helpers to add/modulate glsl vec4s. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by bsalomon
Modified:
11 years, 7 months ago
Reviewers:
robertphillips
CC:
TomH, skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : comment change #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -86 lines) Patch
M src/gpu/gl/GrGLProgram.cpp View 8 chunks +16 lines, -86 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 4 chunks +52 lines, -0 lines 2 comments Download
M src/gpu/gl/GrGLSL.cpp View 2 chunks +77 lines, -0 lines 4 comments Download

Messages

Total messages: 4
bsalomon
Some cleanup on the way to getting rid of fSwizzle and fModulate on GrGLShaderBuilder.
11 years, 7 months ago (2012-08-28 21:59:55 UTC) #1
robertphillips
LGTM + 1 question & 1 comment change request https://codereview.appspot.com/6497046/diff/2001/src/gpu/gl/GrGLSL.cpp File src/gpu/gl/GrGLSL.cpp (right): https://codereview.appspot.com/6497046/diff/2001/src/gpu/gl/GrGLSL.cpp#newcode117 src/gpu/gl/GrGLSL.cpp:117: ...
11 years, 7 months ago (2012-08-29 10:47:27 UTC) #2
bsalomon
https://codereview.appspot.com/6497046/diff/2001/src/gpu/gl/GrGLSL.cpp File src/gpu/gl/GrGLSL.cpp (right): https://codereview.appspot.com/6497046/diff/2001/src/gpu/gl/GrGLSL.cpp#newcode117 src/gpu/gl/GrGLSL.cpp:117: } else { On 2012/08/29 10:47:27, robertphillips wrote: > ...
11 years, 7 months ago (2012-08-29 12:50:18 UTC) #3
bsalomon
11 years, 7 months ago (2012-08-29 13:00:16 UTC) #4
Closed with r5332.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b