mstate: integrated lifecycle into service

mstate: integrated lifecycle into service

Added the lifecycle methods to service and changed
the service removing in state and the according tests.

https://code.launchpad.net/~themue/juju-core/go-mstate-lifecycle-service/+merge/121552

(do not edit description out of merge proposal)

[TheMue, 2012-08-28 08:01:27]

Please take a look.

[TheMue, 2012-08-28 09:34:03]

Please take a look.

[TheMue, 2012-08-28 09:49:40]

Please take a look.

[niemeyer, 2012-08-28 13:48:59]

https://codereview.appspot.com/6495043/diff/2002/mstate/service.go
File mstate/service.go (right):

https://codereview.appspot.com/6495043/diff/2002/mstate/service.go#newcode45
mstate/service.go:45: s.doc.Life = Dying
As discussed on IRC, we'll need to fix the Kill methods.. they're changing the
cached state to Dying irrespective of previous state. We shouldn't do Dying >
Dead.

We can move on like this for now, though, and fix all the Kill methods in a
follow up at once.

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go
File mstate/state.go (right):

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go#newcode162
mstate/state.go:162: err = unit.Die()
What's the win here? You're forcefully destroying all the units.. how is this
any different from deleting it all? What does it mean to "integrate lifecycle"?

[niemeyer, 2012-08-28 13:58:12]

LGTM after IRC conversation, please just add a note:

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go
File mstate/state.go (right):

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go#newcode135
mstate/state.go:135: // TODO(mue) Will change with full txn integration.
// TODO: Integrate with txn and do lifecycle properly. We can't
// remove units like this.

[aram, 2012-08-28 13:59:10]

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go
File mstate/state.go (right):

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go#newcode156
mstate/state.go:156: // Remove the units.
Please add a TODO that this is wrong, and the right thing to do is have units
watch for their own service and kill themselves when needed.

[TheMue, 2012-08-28 14:50:11]

*** Submitted:

mstate: integrated lifecycle into service

Added the lifecycle methods to service and changed
the service removing in state and the according tests.

R=niemeyer, aram
CC=
https://codereview.appspot.com/6495043

https://codereview.appspot.com/6495043/diff/2002/mstate/service.go
File mstate/service.go (right):

https://codereview.appspot.com/6495043/diff/2002/mstate/service.go#newcode45
mstate/service.go:45: s.doc.Life = Dying
On 2012/08/28 13:48:59, niemeyer wrote:
> As discussed on IRC, we'll need to fix the Kill methods.. they're changing the
> cached state to Dying irrespective of previous state. We shouldn't do Dying >
> Dead.
> 
> We can move on like this for now, though, and fix all the Kill methods in a
> follow up at once.

Yep, will get an extra CL.

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go
File mstate/state.go (right):

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go#newcode135
mstate/state.go:135: // TODO(mue) Will change with full txn integration.
On 2012/08/28 13:58:12, niemeyer wrote:
> // TODO: Integrate with txn and do lifecycle properly. We can't
> // remove units like this.

Done.

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go#newcode156
mstate/state.go:156: // Remove the units.
On 2012/08/28 13:59:10, aram wrote:
> Please add a TODO that this is wrong, and the right thing to do is have units
> watch for their own service and kill themselves when needed.

Done.

https://codereview.appspot.com/6495043/diff/2002/mstate/state.go#newcode162
mstate/state.go:162: err = unit.Die()
On 2012/08/28 13:48:59, niemeyer wrote:
> What's the win here? You're forcefully destroying all the units.. how is this
> any different from deleting it all? What does it mean to "integrate
lifecycle"?

Discussed in IRC.