Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(126)

Issue 6493082: code review 6493082: go.net/hgignore: ignore vim swap files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by fss
Modified:
11 years, 6 months ago
Reviewers:
r, adg, golang-dev
Visibility:
Public.

Description

go.net/hgignore: ignore vim swap files

Patch Set 1 #

Patch Set 2 : diff -r 147c4a6dca9b https://code.google.com/p/go.net #

Patch Set 3 : diff -r 147c4a6dca9b https://code.google.com/p/go.net #

Patch Set 4 : diff -r 147c4a6dca9b https://code.google.com/p/go.net #

Patch Set 5 : diff -r 147c4a6dca9b https://code.google.com/p/go.net #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .hgignore View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
fss
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.net
11 years, 6 months ago (2012-09-05 11:59:19 UTC) #1
r
A philosophical question: why should hg ignore other program's junk files? Personally I'd like to ...
11 years, 6 months ago (2012-09-05 12:02:40 UTC) #2
fss
On 2012/09/05 12:02:40, r wrote: > > [cut] > > On a more pragmatic note, ...
11 years, 6 months ago (2012-09-05 14:09:15 UTC) #3
adg
On 5 September 2012 22:02, Rob Pike <r@golang.org> wrote: > A philosophical question: why should ...
11 years, 6 months ago (2012-09-05 14:13:34 UTC) #4
fss
*** Abandoned ***
11 years, 6 months ago (2012-09-05 14:20:20 UTC) #5
fss
11 years, 6 months ago (2012-09-05 14:20:21 UTC) #6
On Wed, Sep 5, 2012 at 11:13 AM, Andrew Gerrand <adg@golang.org> wrote:
> [...]
>
> To avoid checking in your vim temporary files, you (and in this case,
> I) should set your own global ignore rules in $HOME/.hgrc with the
> 'ignore' keyword.

Actually, I configured vim to save swap files somewhere else, but
others might hit this problem in the future, but as Rob said,  code
review will catch them.

-- 
Francisco Souza
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b