A philosophical question: why should hg ignore other program's junk files? Personally I'd like to ...
11 years, 6 months ago
(2012-09-05 12:02:40 UTC)
#2
A philosophical question: why should hg ignore other program's junk
files? Personally I'd like to know they're there so I can clean them
up. If hg is an unusual tool for discovering them, at least it's a
tool. To put it another way, it seems bad engineering to require our
source code repo to know about every temporary file made by every
program out there. Code review will catch anything that slips through
by accident.
On a more pragmatic note, the main repo has just .swp as the
extension. Why should this repo be different?
-rob
On 2012/09/05 12:02:40, r wrote: > > [cut] > > On a more pragmatic note, ...
11 years, 6 months ago
(2012-09-05 14:09:15 UTC)
#3
On 2012/09/05 12:02:40, r wrote:
>
> [cut]
>
> On a more pragmatic note, the main repo has just .swp as the
> extension. Why should this repo be different?
It's because when there's already junk generated by vim, vim generates even more
junk. But I noticed that it's wrong, anyway: when vim finds .swp, it creates
.swo, then .swn, .swm, .swl, etc.
I will send anoter patch set with just .swp to match main repository. Or should
I abandon the CL?
On 5 September 2012 22:02, Rob Pike <r@golang.org> wrote: > A philosophical question: why should ...
11 years, 6 months ago
(2012-09-05 14:13:34 UTC)
#4
On 5 September 2012 22:02, Rob Pike <r@golang.org> wrote:
> A philosophical question: why should hg ignore other program's junk
> files? Personally I'd like to know they're there so I can clean them
> up. If hg is an unusual tool for discovering them, at least it's a
> tool. To put it another way, it seems bad engineering to require our
> source code repo to know about every temporary file made by every
> program out there. Code review will catch anything that slips through
> by accident.
I agree. The .hgignore file should only be used to ignore files
created by the project's build system.
To avoid checking in your vim temporary files, you (and in this case,
I) should set your own global ignore rules in $HOME/.hgrc with the
'ignore' keyword.
Andrew
On Wed, Sep 5, 2012 at 11:13 AM, Andrew Gerrand <adg@golang.org> wrote: > [...] > ...
11 years, 6 months ago
(2012-09-05 14:20:21 UTC)
#6
On Wed, Sep 5, 2012 at 11:13 AM, Andrew Gerrand <adg@golang.org> wrote:
> [...]
>
> To avoid checking in your vim temporary files, you (and in this case,
> I) should set your own global ignore rules in $HOME/.hgrc with the
> 'ignore' keyword.
Actually, I configured vim to save swap files somewhere else, but
others might hit this problem in the future, but as Rob said, code
review will catch them.
--
Francisco Souza
Issue 6493082: code review 6493082: go.net/hgignore: ignore vim swap files
(Closed)
Created 11 years, 6 months ago by fss
Modified 11 years, 6 months ago
Reviewers: golang-dev, r, adg
Base URL:
Comments: 0