Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 6489117: testing: add "series" argument to Repo methods.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by rog
Modified:
11 years, 8 months ago
Reviewers:
mp+124060
Visibility:
Public.

Description

testing: add "series" argument to Repo methods. https://code.launchpad.net/~rogpeppe/juju-core/058-testing-charm-series/+merge/124060 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : testing: add "series" argument to Repo methods. #

Patch Set 3 : testing: add "series" argument to Repo methods. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -69 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M charm/bundle_test.go View 1 5 chunks +5 lines, -5 lines 0 comments Download
M charm/charm_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M charm/config_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M charm/dir_test.go View 1 6 chunks +7 lines, -7 lines 0 comments Download
M charm/meta_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M charm/repo_test.go View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cmd/juju/addunit_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/deploy_test.go View 1 7 chunks +7 lines, -7 lines 0 comments Download
M cmd/juju/expose_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/status_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/unexpose_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M juju/deploy_test.go View 1 6 chunks +6 lines, -6 lines 0 comments Download
M juju/testing/conn.go View 1 1 chunk +1 line, -1 line 0 comments Download
M mstate/conn_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M mstate/state_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M state/state_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M store/branch_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M store/store_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/charm.go View 1 4 chunks +25 lines, -24 lines 0 comments Download
M worker/uniter/charm/charm_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/charm/deployer_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/uniter_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
niemeyer
LGTM with one trivial (but painful, sorry): https://codereview.appspot.com/6489117/diff/1/testing/charm.go File testing/charm.go (right): https://codereview.appspot.com/6489117/diff/1/testing/charm.go#newcode40 testing/charm.go:40: func (r ...
11 years, 8 months ago (2012-09-12 21:42:42 UTC) #1
rog
11 years, 8 months ago (2012-09-12 22:30:39 UTC) #2
*** Submitted:

testing: add "series" argument to Repo methods.

R=niemeyer
CC=
https://codereview.appspot.com/6489117
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b