Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1072)

Issue 6489072: code review 6489072: lib9/dial: fix addrlen in connect() and bind()

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by 0intro
Modified:
11 years, 6 months ago
Reviewers:
rsc
CC:
rsc
Visibility:
Public.

Description

lib9/dial: fix addrlen in connect() and bind() On some systems, the third argument of connect() and bind() is expected to be the length of the address family instead of the length of the sockaddr structure.

Patch Set 1 #

Patch Set 2 : diff -r a72dc30d7892 https://code.google.com/p/plan9port/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M src/lib9/announce.c View 1 3 chunks +18 lines, -4 lines 0 comments Download
M src/lib9/dial.c View 1 4 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 7
0intro
Hello rsc, I'd like you to review this change to https://code.google.com/p/plan9port/
11 years, 6 months ago (2012-09-03 18:47:27 UTC) #1
rsc
LGTM What great timing. listen1 still doesn't work on my Mac, though. Now I get ...
11 years, 6 months ago (2012-09-04 22:45:06 UTC) #2
rsc
*** Submitted as http://code.google.com/p/plan9port/source/detail?r=3f6cb195743a *** lib9/dial: fix addrlen in connect() and bind() On some systems, ...
11 years, 6 months ago (2012-09-04 22:45:26 UTC) #3
0intro
> What great timing. listen1 still doesn't work on my Mac, though. Now > I ...
11 years, 6 months ago (2012-09-05 05:54:37 UTC) #4
0intro
> What great timing. listen1 still doesn't work on my Mac, though. Now > I ...
11 years, 6 months ago (2012-09-05 06:11:48 UTC) #5
0intro
I just did some tests on FreeBSD 9.0 and I haven't encountered this problem. I ...
11 years, 6 months ago (2012-09-06 20:36:37 UTC) #6
rsc
11 years, 6 months ago (2012-09-11 02:18:44 UTC) #7
Just for the review log I believe this is now fixed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b