Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1456)

Issue 6488057: provisioner: changed environment config. test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by TheMue
Modified:
11 years, 8 months ago
Reviewers:
mp+122114
Visibility:
Public.

Description

provisioner: changed environment config. test The tests now check that a changing environment configuration is watched by the provisioner and passed to the environment. https://code.launchpad.net/~themue/juju-core/go-provisioner-environment-test/+merge/122114 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : provisioner: changed environment config. test #

Patch Set 3 : provisioner: changed environment config. test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -31 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M environs/dummy/environs.go View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M worker/provisioner/provisioner_test.go View 1 12 chunks +21 lines, -31 lines 0 comments Download

Messages

Total messages: 4
TheMue
Please take a look.
11 years, 8 months ago (2012-08-30 17:16:59 UTC) #1
TheMue
Please take a look.
11 years, 8 months ago (2012-08-31 12:54:39 UTC) #2
niemeyer
LGTM
11 years, 8 months ago (2012-09-04 14:02:18 UTC) #3
TheMue
11 years, 8 months ago (2012-09-04 16:35:05 UTC) #4
*** Submitted:

provisioner: changed environment config. test

The tests now check that a changing environment configuration
is watched by the provisioner and passed to the environment.

R=niemeyer
CC=
https://codereview.appspot.com/6488057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b