Issue 6485044: environs: tweaks to ListTools interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6485044: environs: tweaks to ListTools interface

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rog

Modified:
11 years, 8 months ago

Reviewers:
mp+120765

Visibility:
Public.

Description

environs: tweaks to ListTools interface This makes it easier for upgrade logic to operate on the set of all available tools. https://code.launchpad.net/~rogpeppe/juju-core/031-list-tools/+merge/120765 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: tweaks to ListTools interface #

Patch Set 3 : environs: tweaks to ListTools interface #

Total comments: 2

Patch Set 4 : environs: tweaks to ListTools interface #

Patch Set 5 : environs: tweaks to ListTools interface #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -160 lines)			Patch
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/tools.go	View	1	3 chunks	+43 lines, -17 lines	0 comments	Download
M	environs/tools_test.go	View	1 2 3	7 chunks	+158 lines, -143 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6485044/diff/4001/environs/tools_test.go File environs/tools_test.go (right): https://codereview.appspot.com/6485044/diff/4001/environs/tools_test.go#newcode671 environs/tools_test.go:671: func (e *storageReaderEnviron) Storage() environs.Storage { This is ...

11 years, 8 months ago (2012-08-22 13:51:23 UTC) #2

rog

11 years, 8 months ago (2012-08-22 14:46:03 UTC) #3

*** Submitted:

environs: tweaks to ListTools interface

This makes it easier for upgrade logic to operate on the set of all
available tools.

R=niemeyer
CC=
https://codereview.appspot.com/6485044

https://codereview.appspot.com/6485044/diff/4001/environs/tools_test.go
File environs/tools_test.go (right):

https://codereview.appspot.com/6485044/diff/4001/environs/tools_test.go#newco...
environs/tools_test.go:671: func (e *storageReaderEnviron) Storage()
environs.Storage {
On 2012/08/22 13:51:23, niemeyer wrote:
> This is getting very hackish, for no apparent reason. This isn't a
> storage*Reader* environ anymore. It'd feel cleaner to simply have a proper
> "storageEnviron" type that returns a storage with the proper methods.

fixed. made some other bits cleaner too.

Expand All Messages | Collapse All Messages