Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1586)

Issue 6482081: environs/dummy: add delay (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by dfc
Modified:
9 years, 8 months ago
Reviewers:
mp+121526, niemeyer
Visibility:
Public.

Description

environs/dummy: add delay This proposal implements a delay in most dummy operations. The delay can be set test wide by setting JUJU_DUMMY_DELAY to a time.Duration parsable value. https://code.launchpad.net/~dave-cheney/juju-core/074-environs-dummy-seniors-moment/+merge/121526 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/dummy: add delay #

Total comments: 2

Patch Set 3 : environs/dummy: add delay #

Patch Set 4 : environs/dummy: add delay #

Total comments: 4

Patch Set 5 : environs/dummy: add delay #

Patch Set 6 : environs/dummy: add delay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M environs/dummy/environs.go View 1 2 3 4 14 chunks +33 lines, -4 lines 0 comments Download

Messages

Total messages: 9
dfc
Please take a look.
9 years, 9 months ago (2012-08-28 02:00:02 UTC) #1
dfc
Please take a look.
9 years, 9 months ago (2012-08-28 02:11:53 UTC) #2
niemeyer
http://codereview.appspot.com/6482081/diff/3001/environs/dummy/environs.go File environs/dummy/environs.go (right): http://codereview.appspot.com/6482081/diff/3001/environs/dummy/environs.go#newcode120 environs/dummy/environs.go:120: <-time.After(e.delayTime) time.Sleep(e.delayTime) http://codereview.appspot.com/6482081/diff/3001/environs/dummy/environs.go#newcode162 environs/dummy/environs.go:162: providerDelay, _ = time.ParseDuration(os.Getenv("JUJU_DUMMY_DELAY")) I'd ...
9 years, 9 months ago (2012-08-28 13:11:56 UTC) #3
dfc
As discussed on IRC I think this is unavoidable in this case as a test ...
9 years, 8 months ago (2012-08-29 04:48:12 UTC) #4
dfc
Please take a look.
9 years, 8 months ago (2012-08-29 04:49:11 UTC) #5
dfc
Please take a look.
9 years, 8 months ago (2012-08-29 04:56:38 UTC) #6
niemeyer
LGTM with the unused variable dropped. https://codereview.appspot.com/6482081/diff/9001/environs/dummy/environs.go File environs/dummy/environs.go (right): https://codereview.appspot.com/6482081/diff/9001/environs/dummy/environs.go#newcode113 environs/dummy/environs.go:113: delayTime time.Duration // ...
9 years, 8 months ago (2012-08-29 13:32:48 UTC) #7
dfc
Please take a look. https://codereview.appspot.com/6482081/diff/9001/environs/dummy/environs.go File environs/dummy/environs.go (right): https://codereview.appspot.com/6482081/diff/9001/environs/dummy/environs.go#newcode113 environs/dummy/environs.go:113: delayTime time.Duration // delay before ...
9 years, 8 months ago (2012-08-29 23:14:11 UTC) #8
dfc
9 years, 8 months ago (2012-08-29 23:26:39 UTC) #9
*** Submitted:

environs/dummy: add delay

This proposal implements a delay in most dummy operations. The delay 
can be set test wide by setting JUJU_DUMMY_DELAY to a time.Duration 
parsable value.

R=niemeyer
CC=
https://codereview.appspot.com/6482081
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b