Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 6460: Upload empty content for binary files to set correct upload status. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 8 months ago by Andi
Modified:
13 years, 10 months ago
Reviewers:
JohnA, GvR
Visibility:
Public.

Description

Fix for Issue 54: http://code.google.com/p/rietveld/issues/detail?id=54 Holding back in favor of http://codereview.appspot.com/6455 and http://codereview.appspot.com/7263/show Currently no base content for binary files (except images, of course) is uploaded to Rietveld. A Content instance is created but since there's no upload Content.text remains None which causes a 404 when viewing sbs. This patch sets the default for base_content from None to "" (empty string) in upload.py. To reproduce this issue: [go to Rietveld's trunk directory] $ cp django.zip foo.zip $ svn add foo.zip $ upload.py -s localhost:8080 -y -m "test issue54"

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M static/upload.py View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Andi Albrecht
17 years, 8 months ago (2008-10-02 05:01:22 UTC) #1
JohnA
hmm, instead of doing this (which slows upload and might confuse a user), why not ...
17 years, 8 months ago (2008-10-02 20:40:25 UTC) #2
JohnA
17 years, 8 months ago (2008-10-02 21:36:39 UTC) #3
nm, my suggestion still leaves an empty status.  LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b