Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4048)

Issue 6458094: less spam

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by fwereade
Modified:
11 years, 8 months ago
Reviewers:
mp+118590
Visibility:
Public.

Description

less spam (help is only printed on --help, not on any cmd parse error) https://code.launchpad.net/~fwereade/juju-core/fix-cmd-usage/+merge/118590 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : less spam #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -64 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/cmd.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/cmd_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/main_test.go View 4 chunks +49 lines, -48 lines 0 comments Download
M cmd/jujuc/main_test.go View 1 chunk +3 lines, -2 lines 0 comments Download
M cmd/jujuc/server/server_test.go View 1 chunk +1 line, -10 lines 0 comments Download
M cmd/output_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/tools_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
fwereade
Please take a look.
11 years, 8 months ago (2012-08-07 16:24:58 UTC) #1
niemeyer
That's great. LGTM https://codereview.appspot.com/6458094/diff/1/cmd/juju/main_test.go File cmd/juju/main_test.go (right): https://codereview.appspot.com/6458094/diff/1/cmd/juju/main_test.go#newcode46 cmd/juju/main_test.go:46: var runMainTests = []struct { Nice, ...
11 years, 8 months ago (2012-08-07 16:41:08 UTC) #2
fwereade
11 years, 8 months ago (2012-08-07 16:45:10 UTC) #3
*** Submitted:

less spam

(help is only printed on --help, not on any cmd parse error)

R=niemeyer
CC=
https://codereview.appspot.com/6458094
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b