Stat speed up via minimizing provider api usage.

Stat speed up via minimizing provider api usage.

extracted the stat speed up from the provider api changes around get_machines in 
big-oh-stat-improv. branch is much smaller as a result and tackles the 
provider interaction improvement by itself.

https://code.launchpad.net/~hazmat/juju/stat-potato/+merge/118258

(do not edit description out of merge proposal)

[hazmat, 2012-08-05 00:27:10]

Please take a look.

[gz, 2012-08-06 13:12:11]

Looks good.

Some tests with a faked provider would be nice to assert that only one
get_machines call is used, and exercise the error paths. The current status
tests all seem pretty heavy though.

https://codereview.appspot.com/6455088/diff/1/juju/control/status.py
File juju/control/status.py (right):

https://codereview.appspot.com/6455088/diff/1/juju/control/status.py#newcode545
juju/control/status.py:545: self.log.exception(
Switching from log.exception to log.error here seems to have been missed.

[hazmat, 2012-08-09 09:20:33]

added an additional test varifying api calls to provider.

https://codereview.appspot.com/6455088/diff/1/juju/control/status.py
File juju/control/status.py (right):

https://codereview.appspot.com/6455088/diff/1/juju/control/status.py#newcode545
juju/control/status.py:545: self.log.exception(
On 2012/08/06 13:12:12, gz wrote:
> Switching from log.exception to log.error here seems to have been missed.

previous comment was there was no exception state anymore, which isn't true,
here's a quick example to show otherwise..

>>> import logging
>>> try:
...   raise SyntaxError
... except:
...   logging.basicConfig()
...   logging.exception('abc')
ERROR:root:abc
Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
SyntaxError: None

[hazmat, 2012-08-09 11:01:45]

*** Submitted:

Stat speed up via minimizing provider api usage.

extracted the stat speed up from the provider api changes around get_machines in

big-oh-stat-improv. branch is much smaller as a result and tackles the 
provider interaction improvement by itself.

R=gz
CC=
https://codereview.appspot.com/6455088